Changeset 78445be8 in mainline

Timestamp:

2020-06-24T22:48:37Z (4 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

de19d4a

Parents:

8630748

Message:

Log message strings should not have a newline at the end

Location:

uspace/srv/hid/display

Files:

• ddev.c (modified) (5 diffs)
• input.c (modified) (3 diffs)
• output.c (modified) (5 diffs)
• window.c (modified) (3 diffs)

uspace/srv/hid/display/ddev.c

@@ -100 +100 @@
         if (rc != EOK) {
                 log_msg(LOG_DEFAULT, LVL_ERROR,
-                    "Error resolving name of service %lu.\n",
+                    "Error resolving name of service %lu.",
                     (unsigned long) svc_id);
                 return rc;
@@ -108 +108 @@
         if (rc != EOK) {
                 log_msg(LOG_DEFAULT, LVL_ERROR,
-                    "Error opening display device '%s'.\n", name);
+                    "Error opening display device '%s'.", name);
                 free(name);
                 return rc;
@@ -116 +116 @@
         if (rc != EOK) {
                 log_msg(LOG_DEFAULT, LVL_ERROR,
-                    "Error getting information for display device '%s'.\n",
+                    "Error getting information for display device '%s'.",
                     name);
                 free(name);
@@ -124 +124 @@
 
         log_msg(LOG_DEFAULT, LVL_DEBUG, "Device rectangle for '%s': "
-            "%d,%d,%d,%d\n", name, info.rect.p0.x, info.rect.p0.y,
+            "%d,%d,%d,%d", name, info.rect.p0.x, info.rect.p0.y,
             info.rect.p1.x, info.rect.p1.y);
 
@@ -130 +130 @@
         if (rc != EOK) {
                 log_msg(LOG_DEFAULT, LVL_ERROR,
-                    "Error getting device context for '%s'.\n", name);
+                    "Error getting device context for '%s'.", name);
                 ddev_close(dd);
                 free(name);

uspace/srv/hid/display/input.c

@@ -153 +153 @@
         errno_t rc = loc_service_get_id(svc, &dsid, 0);
         if (rc != EOK) {
-                log_msg(LOG_DEFAULT, LVL_ERROR, "Input service %s not found\n",
+                log_msg(LOG_DEFAULT, LVL_ERROR, "Input service %s not found",
                     svc);
                 return rc;
@@ -161 +161 @@
         if (sess == NULL) {
                 log_msg(LOG_DEFAULT, LVL_ERROR,
-                    "Unable to connect to input service %s\n", svc);
+                    "Unable to connect to input service %s", svc);
                 return EIO;
         }
@@ -170 +170 @@
                 async_hangup(sess);
                 log_msg(LOG_DEFAULT, LVL_ERROR,
-                    "Unable to communicate with service %s (%s)\n",
+                    "Unable to communicate with service %s (%s)",
                     svc, str_error(rc));
                 return rc;

uspace/srv/hid/display/output.c

@@ -64 +64 @@
         if (rc != EOK) {
                 log_msg(LOG_DEFAULT, LVL_ERROR,
-                    "Error looking up category 'display-device'.\n");
+                    "Error looking up category 'display-device'.");
                 return EIO;
         }
@@ -74 +74 @@
         if (rc != EOK) {
                 log_msg(LOG_DEFAULT, LVL_ERROR,
-                    "Error getting list of display devices.\n");
+                    "Error getting list of display devices.");
                 return EIO;
         }
@@ -93 +93 @@
                         if (rc != EOK) {
                                 log_msg(LOG_DEFAULT, LVL_ERROR,
-                                    "Error adding display device.\n");
+                                    "Error adding display device.");
                                 continue;
                         }
@@ -100 +100 @@
 
                         log_msg(LOG_DEFAULT, LVL_NOTE,
-                            "Added display device '%lu'\n",
+                            "Added display device '%lu'",
                             (unsigned long) svcs[i]);
                 }
@@ -155 +155 @@
         if (rc != EOK) {
                 log_msg(LOG_DEFAULT, LVL_ERROR,
-                    "Failed registering callback for device discovery.\n");
+                    "Failed registering callback for device discovery.");
                 return rc;
         }

uspace/srv/hid/display/window.c

@@ -561 +561 @@
 
         log_msg(LOG_DEFAULT, LVL_DEBUG,
-            "ds_window_post_pos_event type=%d pos=%d,%d\n", event->type,
+            "ds_window_post_pos_event type=%d pos=%d,%d", event->type,
             (int) event->hpos, (int) event->vpos);
 
@@ -612 +612 @@
 errno_t ds_window_post_focus_event(ds_window_t *wnd)
 {
-        log_msg(LOG_DEFAULT, LVL_DEBUG, "ds_window_post_focus_event\n");
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "ds_window_post_focus_event");
 
         return ds_client_post_focus_event(wnd->client, wnd);
@@ -623 +623 @@
 errno_t ds_window_post_unfocus_event(ds_window_t *wnd)
 {
-        log_msg(LOG_DEFAULT, LVL_DEBUG, "ds_window_post_unfocus_event\n");
+        log_msg(LOG_DEFAULT, LVL_DEBUG, "ds_window_post_unfocus_event");
 
         return ds_client_post_unfocus_event(wnd->client, wnd);