Changeset 774e6d1a in mainline for uspace/srv/net/tl/icmp/icmp.c

Timestamp:

2011-01-09T23:24:53Z (13 years ago)

Author:

martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4b86dac

Parents:

3c106e88

Message:

partial networking stack overhaul

• a lot of coding style changes (comments, indentation, etc.)
• convert several ints to unsigned ints or size_t values
• streamline many of the IPC-related macros (they no longer dereference the call structure by themselves)
• get rid of netif_interface.h (containing only aliases for remote functions and not serving any purpose)
• rename netif_local.{c|h} to netif_skel.{c|h} (it is really just a skeleton)
• drop the "_remote" and "_standalone" suffixes from most of the netif_ functions (they do not serve any purpose anymore)
• implement netif_client_connection() as a common framework function for all netif modules
  • update the lo module accordingly
• ip module now reports the default gateway to the user whenever it is being set

File:

• uspace/srv/net/tl/icmp/icmp.c (modified) (6 diffs)

uspace/srv/net/tl/icmp/icmp.c

@@ -696 +696 @@
         case NET_ICMP_DEST_UNREACH:
                 rc = packet_translate_remote(icmp_globals.net_phone, &packet,
-                    IPC_GET_PACKET(call));
+                    IPC_GET_PACKET(*call));
                 if (rc != EOK)
                         return rc;
                 return icmp_destination_unreachable_msg_local(0,
-                    ICMP_GET_CODE(call), ICMP_GET_MTU(call), packet);
+                    ICMP_GET_CODE(*call), ICMP_GET_MTU(*call), packet);
         case NET_ICMP_SOURCE_QUENCH:
                 rc = packet_translate_remote(icmp_globals.net_phone, &packet,
-                    IPC_GET_PACKET(call));
+                    IPC_GET_PACKET(*call));
                 if (rc != EOK)
                         return rc;
@@ -709 +709 @@
         case NET_ICMP_TIME_EXCEEDED:
                 rc = packet_translate_remote(icmp_globals.net_phone, &packet,
-                    IPC_GET_PACKET(call));
+                    IPC_GET_PACKET(*call));
                 if (rc != EOK)
                         return rc;
-                return icmp_time_exceeded_msg_local(0, ICMP_GET_CODE(call),
+                return icmp_time_exceeded_msg_local(0, ICMP_GET_CODE(*call),
                     packet);
         case NET_ICMP_PARAMETERPROB:
                 rc = packet_translate_remote(icmp_globals.net_phone, &packet,
-                    IPC_GET_PACKET(call));
+                    IPC_GET_PACKET(*call));
                 if (rc != EOK)
                         return rc;
-                return icmp_parameter_problem_msg_local(0, ICMP_GET_CODE(call),
-                    ICMP_GET_POINTER(call), packet);
+                return icmp_parameter_problem_msg_local(0, ICMP_GET_CODE(*call),
+                    ICMP_GET_POINTER(*call), packet);
         default:
                 return ENOTSUP;
@@ -787 +787 @@
         bool keep_on_going = true;
         ipc_call_t answer;
-        int answer_count;
+        size_t answer_count;
         size_t length;
         struct sockaddr *addr;
@@ -894 +894 @@
  */
 int icmp_message_standalone(ipc_callid_t callid, ipc_call_t *call,
-    ipc_call_t *answer, int *answer_count)
+    ipc_call_t *answer, size_t *answer_count)
 {
         packet_t *packet;
@@ -903 +903 @@
         case NET_TL_RECEIVED:
                 rc = packet_translate_remote(icmp_globals.net_phone, &packet,
-                    IPC_GET_PACKET(call));
+                    IPC_GET_PACKET(*call));
                 if (rc != EOK)
                         return rc;
-                return icmp_received_msg_local(IPC_GET_DEVICE(call), packet,
-                    SERVICE_ICMP, IPC_GET_ERROR(call));
+                return icmp_received_msg_local(IPC_GET_DEVICE(*call), packet,
+                    SERVICE_ICMP, IPC_GET_ERROR(*call));
         
         case NET_ICMP_INIT:
-                return icmp_process_client_messages(callid, * call);
+                return icmp_process_client_messages(callid, *call);
         
         default:
@@ -936 +936 @@
         while (true) {
                 ipc_call_t answer;
-                int answer_count;
+                size_t answer_count;
                 
                 /* Clear the answer structure */