Changeset 774e6d1a in mainline for uspace/srv/net/il/arp/arp.c

Timestamp:

2011-01-09T23:24:53Z (13 years ago)

Author:

martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4b86dac

Parents:

3c106e88

Message:

partial networking stack overhaul

• a lot of coding style changes (comments, indentation, etc.)
• convert several ints to unsigned ints or size_t values
• streamline many of the IPC-related macros (they no longer dereference the call structure by themselves)
• get rid of netif_interface.h (containing only aliases for remote functions and not serving any purpose)
• rename netif_local.{c|h} to netif_skel.{c|h} (it is really just a skeleton)
• drop the "_remote" and "_standalone" suffixes from most of the netif_ functions (they do not serve any purpose anymore)
• implement netif_client_connection() as a common framework function for all netif modules
  • update the lo module accordingly
• ip module now reports the default gateway to the user whenever it is being set

File:

• uspace/srv/net/il/arp/arp.c (modified) (12 diffs)

uspace/srv/net/il/arp/arp.c

@@ -457 +457 @@
         uint8_t *des_proto;
         int rc;
-
+        
         length = packet_get_data_length(packet);
         if (length <= sizeof(arp_header_t))
@@ -677 +677 @@
 int
 arp_message_standalone(ipc_callid_t callid, ipc_call_t *call,
-    ipc_call_t *answer, int *answer_count)
+    ipc_call_t *answer, size_t *answer_count)
 {
         measured_string_t *address;
@@ -696 +696 @@
                         return rc;
                 
-                rc = arp_device_message(IPC_GET_DEVICE(call),
-                    IPC_GET_SERVICE(call), ARP_GET_NETIF(call), address);
+                rc = arp_device_message(IPC_GET_DEVICE(*call),
+                    IPC_GET_SERVICE(*call), ARP_GET_NETIF(*call), address);
                 if (rc != EOK) {
                         free(address);
@@ -710 +710 @@
                 
                 fibril_mutex_lock(&arp_globals.lock);
-                rc = arp_translate_message(IPC_GET_DEVICE(call),
-                    IPC_GET_SERVICE(call), address, &translation);
+                rc = arp_translate_message(IPC_GET_DEVICE(*call),
+                    IPC_GET_SERVICE(*call), address, &translation);
                 free(address);
                 free(data);
@@ -727 +727 @@
 
         case NET_ARP_CLEAR_DEVICE:
-                return arp_clear_device_req(0, IPC_GET_DEVICE(call));
+                return arp_clear_device_req(0, IPC_GET_DEVICE(*call));
 
         case NET_ARP_CLEAR_ADDRESS:
@@ -734 +734 @@
                         return rc;
                 
-                arp_clear_address_req(0, IPC_GET_DEVICE(call),
-                    IPC_GET_SERVICE(call), address);
+                arp_clear_address_req(0, IPC_GET_DEVICE(*call),
+                    IPC_GET_SERVICE(*call), address);
                 free(address);
                 free(data);
@@ -750 +750 @@
                 
                 rc = packet_translate_remote(arp_globals.net_phone, &packet,
-                    IPC_GET_PACKET(call));
+                    IPC_GET_PACKET(*call));
                 if (rc != EOK)
                         return rc;
@@ -757 +757 @@
                 do {
                         next = pq_detach(packet);
-                        rc = arp_receive_message(IPC_GET_DEVICE(call), packet);
+                        rc = arp_receive_message(IPC_GET_DEVICE(*call), packet);
                         if (rc != 1) {
                                 pq_release_remote(arp_globals.net_phone,
@@ -769 +769 @@
         
         case NET_IL_MTU_CHANGED:
-                return arp_mtu_changed_message(IPC_GET_DEVICE(call),
-                    IPC_GET_MTU(call));
+                return arp_mtu_changed_message(IPC_GET_DEVICE(*call),
+                    IPC_GET_MTU(*call));
         }
         
@@ -791 +791 @@
         while (true) {
                 ipc_call_t answer;
-                int answer_count;
+                size_t count;
                 
                 /* Clear the answer structure */
-                refresh_answer(&answer, &answer_count);
+                refresh_answer(&answer, &count);
                 
                 /* Fetch the next message */
@@ -802 +802 @@
                 /* Process the message */
                 int res = il_module_message_standalone(callid, &call, &answer,
-                    &answer_count);
+                    &count);
                 
                 /*
@@ -813 +813 @@
                 
                 /* Answer the message */
-                answer_call(callid, res, &answer, answer_count);
+                answer_call(callid, res, &answer, count);
         }
 }