Changeset 7473807 in mainline for kernel/generic/src/proc/program.c

Timestamp:

2018-05-11T20:22:42Z (6 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d2c5159

Parents:

ae89656

Message:

Use atomic malloc allocations

We can safely use atomic allocations in places that use the non-failing
version of malloc(), but test the return value anyway. And also in some
places that can afford to return failure but did not because of comfort.

File:

• kernel/generic/src/proc/program.c (modified) (2 diffs)

kernel/generic/src/proc/program.c

@@ -71 +71 @@
 errno_t program_create(as_t *as, uintptr_t entry_addr, char *name, program_t *prg)
 {
+        uspace_arg_t *kernel_uarg = (uspace_arg_t *)
+            malloc(sizeof(uspace_arg_t), FRAME_ATOMIC);
+        if (!kernel_uarg)
+                return ENOMEM;
+
         prg->loader_status = EE_OK;
         prg->task = task_create(as, name);
-        if (!prg->task)
+        if (!prg->task) {
+                free(kernel_uarg);
                 return ELIMIT;
+        }
 
         /*
@@ -90 +97 @@
             &anon_backend, NULL, &virt, bound);
         if (!area) {
+                free(kernel_uarg);
                 task_destroy(prg->task);
                 prg->task = NULL;
                 return ENOMEM;
         }
-
-        uspace_arg_t *kernel_uarg = (uspace_arg_t *)
-            malloc(sizeof(uspace_arg_t), 0);
 
         kernel_uarg->uspace_entry = (void *) entry_addr;