Fork us on GitHub Follow us on Facebook Follow us on Twitter

Changeset 6fc4a32 in mainline


Ignore:
Timestamp:
2018-10-29T17:15:02Z (3 years ago)
Author:
Jakub Jermar <jakub@…>
Children:
f230cbd
Parents:
eec201d
git-author:
Jakub Jermar <jakub@…> (2018-10-28 14:28:41)
git-committer:
Jakub Jermar <jakub@…> (2018-10-29 17:15:02)
Message:

Do not leave connected phones behind

The connection structure is deallocated when client_connection returns.
We must therefore not leave any connected phones behind or else any
incoming call (e.g. IPC_M_PHONE_HUNGUP) will attempt to use the
deallocated connection structure since its address is still stored as a
label in the phone and copied to the call.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/srv/hid/compositor/compositor.c

    reec201d r6fc4a32  
    926926                        window_t *win = window_create();
    927927                        if (!win) {
    928                                 async_answer_2(&call, ENOMEM, 0, 0);
     928                                async_answer_0(&call, EHANGUP);
    929929                                fibril_mutex_unlock(&window_list_mtx);
    930930                                return;
     
    945945                        if (loc_service_register(name_in, &win->in_dsid) != EOK) {
    946946                                window_destroy(win);
    947                                 async_answer_2(&call, EINVAL, 0, 0);
     947                                async_answer_0(&call, EHANGUP);
    948948                                fibril_mutex_unlock(&window_list_mtx);
    949949                                return;
     
    953953                                loc_service_unregister(win->in_dsid);
    954954                                window_destroy(win);
    955                                 async_answer_2(&call, EINVAL, 0, 0);
     955                                async_answer_0(&call, EHANGUP);
    956956                                fibril_mutex_unlock(&window_list_mtx);
    957957                                return;
     
    974974                        }
    975975
    976                         return;
    977                 } else {
    978                         async_answer_0(&call, EINVAL);
    979                         return;
    980                 }
     976                        async_get_call(&call);
     977                }
     978                async_answer_0(&call, EHANGUP);
     979                return;
    981980        }
    982981
Note: See TracChangeset for help on using the changeset viewer.