Changeset 6d87dce in mainline

Timestamp:

2016-05-04T17:39:46Z (8 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

650cd22

Parents:

9a08e6b

Message:

Use raw fibril synchronization in fibril_setup()

With some configurations, fibril_lock/unlock() may attempt to access TLS.
We therefore need to be careful in fibril_setup(), which is called before
tcb_setup(), to use fibril_down/up() instead.

File:

• uspace/lib/c/generic/fibril.c (modified) (1 diff)

uspace/lib/c/generic/fibril.c

@@ -114 +114 @@
         fibril->waits_for = NULL;
 
-        futex_lock(&fibril_futex);
+        /*
+         * We are called before __tcb_set(), so we need to use
+         * futex_down/up() instead of futex_lock/unlock() that
+         * may attempt to access TLS.
+         */
+        futex_down(&fibril_futex);
         list_append(&fibril->all_link, &fibril_list);
-        futex_unlock(&fibril_futex);
+        futex_up(&fibril_futex);
         
         return fibril;