Changeset 63a045c in mainline for boot/arch/riscv64/src/main.c

Timestamp:

2018-10-10T17:41:44Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9286475

Parents:

63c1dd5

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-10-10 17:11:15)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-10-10 17:41:44)

Message:

Unify handling of compressed init data and use regular tar + gzip to achieve it

There are two issues this commit solves.

First is that architecture-specific code duplicates most of the init binary
handling in each architecture, each with miniscule and confusing variations.
After this commit, the init binary expansion is almost entirely handled by
unified generic code.

Second is that the way we used to generate the incorporated data is somewhat
convoluted. Previously we have a Python script which generates a zip archive
with individual deflate-compressed files and accompanying header and C files
which contain structures describing the archive contents.
The zip file is then extracted and the individual deflate-compressed files are
included in the binary via assembler code.
Since gas doesn't take particular care to be consistent between architectures,
the assembly portions are also not uniform and the build script needs to know
particulars of the architecture's assembly.

Instead of doing that, after this commit we first gzip each included file, then
we pack the gzipped files into a tar archive, and then we include the archive
into the binary using objcopy.
Linker script provides symbols for the start and end of the archive,
and the payload is in a self-describing format, so there is no need for any
generated code.

Note that we are doing the opposite of the conventional .tar.gz format.
It would be somewhat inconvenient to use .tar.gz since the uncompressed files
need to be aligned to page size, so we'd have to first decompress the entire
payload to determine the final position of the files (and hence the required
amount of memory).

File:

• boot/arch/riscv64/src/main.c (modified) (2 diffs)

boot/arch/riscv64/src/main.c

@@ -41 +41 @@
 #include <str.h>
 #include <halt.h>
-#include <inflate.h>
-#include "../../components.h"
+#include <payload.h>
 
 static bootinfo_t bootinfo;
@@ -69 +68 @@
         printf(" %p: boot info structure\n", &bootinfo);
 
-        uintptr_t top = BOOT_OFFSET;
+        uint8_t *load_addr = (uint8_t *) BOOT_OFFSET;
+        uintptr_t kernel_addr = PA2KA(load_addr);
 
-        for (size_t i = 0; i < COMPONENTS; i++) {
-                printf(" %p: %s image (%zu/%zu bytes)\n", components[i].addr,
-                    components[i].name, components[i].inflated,
-                    components[i].size);
+        printf(" %p: inflate area\n", load_addr);
+        printf(" %p: kernel entry point\n", (void *) kernel_addr);
 
-                uintptr_t tail = (uintptr_t) components[i].addr +
-                    components[i].size;
-                if (tail > top) {
-                        printf("\n%s: Image too large to fit (%p >= %p), halting.\n",
-                            components[i].name, (void *) tail, (void *) top);
-                        halt();
+        /* Find the end of the memory zone containing the load address. */
+        uint8_t *end = NULL;
+        for (size_t i = 0; i < bootinfo.memmap.cnt; i++) {
+                memzone_t z = bootinfo.memmap.zones[i];
+
+                if (z.start <= (void *) load_addr &&
+                    z.start + z.size > (void *) load_addr) {
+                        end = z.start + z.size;
                 }
         }
 
-        printf(" %p: inflate area\n", (void *) top);
-
-        void *kernel_entry = NULL;
-        void *dest[COMPONENTS];
-        size_t cnt = 0;
-        bootinfo.taskmap.cnt = 0;
-
-        for (size_t i = 0; i < min(COMPONENTS, TASKMAP_MAX_RECORDS); i++) {
-                top = ALIGN_UP(top, PAGE_SIZE);
-
-                if (i > 0) {
-                        bootinfo.taskmap.tasks[bootinfo.taskmap.cnt].addr =
-                            (void *) PA2KA(top);
-                        bootinfo.taskmap.tasks[bootinfo.taskmap.cnt].size =
-                            components[i].inflated;
-
-                        str_cpy(bootinfo.taskmap.tasks[bootinfo.taskmap.cnt].name,
-                            BOOTINFO_TASK_NAME_BUFLEN, components[i].name);
-
-                        bootinfo.taskmap.cnt++;
-                } else
-                        kernel_entry = (void *) PA2KA(top);
-
-                dest[i] = (void *) top;
-                top += components[i].inflated;
-                cnt++;
-        }
-
-        printf(" %p: kernel entry point\n", kernel_entry);
-
-        if (top >= bootinfo.physmem_start + bootinfo.memmap.total) {
-                printf("Not enough physical memory available.\n");
-                printf("The boot image is too large. Halting.\n");
-                halt();
-        }
-
-        printf("\nInflating components ... ");
-
-        for (size_t i = cnt; i > 0; i--) {
-                printf("%s ", components[i - 1].name);
-
-                int err = inflate(components[i - 1].addr, components[i - 1].size,
-                    dest[i - 1], components[i - 1].inflated);
-
-                if (err != EOK) {
-                        printf("\n%s: Inflating error %d, halting.\n",
-                            components[i - 1].name, err);
-                        halt();
-                }
-        }
-
-        printf(".\n");
+        // TODO: Cache-coherence callback?
+        extract_payload(&bootinfo.taskmap, load_addr, end, kernel_addr, NULL);
 
         printf("Booting the kernel...\n");