Changeset 61727bf in mainline

Timestamp:

2011-04-08T17:48:47Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

39db23f, 8961c22, 8e8b84f, c6cb76d, d5ac90f

Parents:

85c47729

Message:

Adding new devices can be done in parallel

The wrapper for adding new device duplicates the connection, thus
allowing more parallel device discovery.

File:

• uspace/lib/usb/src/hub.c (modified) (8 diffs)

uspace/lib/usb/src/hub.c

@@ -178 +178 @@
  * error codes than those listed as return codes by this function itself).
  *
+ * The @p connection representing connection with host controller does not
+ * need to be started.
+ * This function duplicates the connection to allow simultaneous calls of
+ * this function (i.e. from different fibrils).
+ *
  * @param[in] parent Parent device (i.e. the hub device).
- * @param[in] connection Opened connection to host controller.
+ * @param[in] connection Connection to host controller.
  * @param[in] dev_speed New device speed.
  * @param[in] enable_port Function for enabling signaling through the port the
@@ -206 +211 @@
     ddf_dev_ops_t *dev_ops, void *new_dev_data, ddf_fun_t **new_fun)
 {
-        CHECK_CONNECTION(connection);
+        assert(connection != NULL);
+        // FIXME: this is awful, we are accessing directly the structure.
+        usb_hc_connection_t hc_conn = {
+                .hc_handle = connection->hc_handle,
+                .hc_phone = -1
+        };
+
+        int rc;
+
+        rc = usb_hc_connection_open(&hc_conn);
+        if (rc != EOK) {
+                return rc;
+        }
+
 
         /*
          * Request new address.
          */
-        usb_address_t dev_addr = usb_hc_request_address(connection, dev_speed);
+        usb_address_t dev_addr = usb_hc_request_address(&hc_conn, dev_speed);
         if (dev_addr < 0) {
+                usb_hc_connection_close(&hc_conn);
                 return EADDRNOTAVAIL;
         }
 
-        int rc;
 
         /*
          * Reserve the default address.
          */
-        rc = usb_hc_reserve_default_address(connection, dev_speed);
+        rc = usb_hc_reserve_default_address(&hc_conn, dev_speed);
         if (rc != EOK) {
                 rc = EBUSY;
@@ -241 +259 @@
         usb_device_connection_t dev_conn;
         rc = usb_device_connection_initialize_on_default_address(&dev_conn,
-            connection);
+            &hc_conn);
         if (rc != EOK) {
                 rc = ENOTCONN;
@@ -258 +276 @@
          * endpoint.
          */
-        rc = usb_pipe_register(&ctrl_pipe, 0, connection);
+        rc = usb_pipe_register(&ctrl_pipe, 0, &hc_conn);
         if (rc != EOK) {
                 rc = EREFUSED;
@@ -286 +304 @@
          * Register the control endpoint for the new device.
          */
-        rc = usb_pipe_register(&ctrl_pipe, 0, connection);
+        rc = usb_pipe_register(&ctrl_pipe, 0, &hc_conn);
         if (rc != EOK) {
                 rc = EREFUSED;
@@ -295 +313 @@
          * Release the original endpoint.
          */
-        unregister_control_endpoint_on_default_address(connection);
+        unregister_control_endpoint_on_default_address(&hc_conn);
 
         /*
          * Once the address is changed, we can return the default address.
          */
-        usb_hc_release_default_address(connection);
+        usb_hc_release_default_address(&hc_conn);
 
 
@@ -325 +343 @@
                 .handle = child_handle
         };
-        rc = usb_hc_register_device(connection, &new_device);
+        rc = usb_hc_register_device(&hc_conn, &new_device);
         if (rc != EOK) {
                 rc = EDESTADDRREQ;
@@ -354 +372 @@
 
 leave_unregister_endpoint:
-        usb_pipe_unregister(&ctrl_pipe, connection);
+        usb_pipe_unregister(&ctrl_pipe, &hc_conn);
 
 leave_release_default_address:
-        usb_hc_release_default_address(connection);
+        usb_hc_release_default_address(&hc_conn);
 
 leave_release_free_address:
-        usb_hc_unregister_device(connection, dev_addr);
+        usb_hc_unregister_device(&hc_conn, dev_addr);
+
+        usb_hc_connection_close(&hc_conn);
 
         return rc;