Changeset 6119f24 in mainline for uspace/app/klog/klog.c

Timestamp:

2011-01-29T18:58:24Z (13 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

10477601, 6aef742

Parents:

d7533c7

Message:

map klog area and clock page directly in tasks which require them (do not use the memory sharing from naming service via IPC)
this avoids the circular dependency between gettimeofday() and the async framework (as reported by Jakub Jermar)
it also simplifies the code of the naming service (the memory sharing was never strictly necessary, it was only a demonstrator)

File:

• uspace/app/klog/klog.c (modified) (2 diffs)

uspace/app/klog/klog.c

@@ -36 +36 @@
 
 #include <stdio.h>
-#include <ipc/ns.h>
 #include <async.h>
-#include <ipc/services.h>
 #include <as.h>
-#include <sysinfo.h>
+#include <ddi.h>
 #include <event.h>
 #include <errno.h>
 #include <str_error.h>
 #include <io/klog.h>
+#include <sysinfo.h>
 
 #define NAME       "klog"
@@ -79 +78 @@
 int main(int argc, char *argv[])
 {
-        klog = service_klog_share_in(&klog_length);
-        if (klog == NULL) {
-                printf("%s: Error accessing to klog\n", NAME);
-                return -1;
+        size_t pages;
+        int rc = sysinfo_get_value("klog.pages", &pages);
+        if (rc != EOK) {
+                fprintf(stderr, "%s: Unable to get number of klog pages\n",
+                    NAME);
+                return rc;
         }
         
-        if (event_subscribe(EVENT_KLOG, 0) != EOK) {
-                printf("%s: Error registering klog notifications\n", NAME);
-                return -1;
+        uintptr_t faddr;
+        rc = sysinfo_get_value("klog.faddr", &faddr);
+        if (rc != EOK) {
+                fprintf(stderr, "%s: Unable to get klog physical address\n",
+                    NAME);
+                return rc;
+        }
+        
+        size_t size = pages * PAGE_SIZE;
+        klog_length = size / sizeof(wchar_t);
+        
+        klog = (wchar_t *) as_get_mappable_page(size);
+        if (klog == NULL) {
+                fprintf(stderr, "%s: Unable to allocate virtual memory area\n",
+                    NAME);
+                return ENOMEM;
+        }
+        
+        rc = physmem_map((void *) faddr, (void *) klog, pages,
+            AS_AREA_READ | AS_AREA_CACHEABLE);
+        if (rc != EOK) {
+                fprintf(stderr, "%s: Unable to map klog\n", NAME);
+                return rc;
+        }
+        
+        rc = event_subscribe(EVENT_KLOG, 0);
+        if (rc != EOK) {
+                fprintf(stderr, "%s: Unable to register klog notifications\n",
+                    NAME);
+                return rc;
         }