Changeset 5f6e25e in mainline for uspace/drv/bus/usb/usbhid/multimedia/multimedia.c

Timestamp:

2011-08-29T23:00:12Z (13 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

58cbb0c8

Parents:

c5be39b

Message:

Leave it up to DDF to free driver-specific data. This makes it possible
to ensure soft state is not freed during calls to driver entry points.

This requires some driver changes:

• minimum change is not to free() driver-data structures (ddf_fun_t.driver_data and ddf_dev_t.driver_data)
• ideally allocate using ddf_dev_data_alloc(), ddf_fun_data_alloc()

I tried fixing existing drivers accordingly (mostly the minimalistic
change variant), but could have missed something.

File:

• uspace/drv/bus/usb/usbhid/multimedia/multimedia.c (modified) (3 diffs)

uspace/drv/bus/usb/usbhid/multimedia/multimedia.c

@@ -167 +167 @@
 /*----------------------------------------------------------------------------*/
 
-static void usb_multimedia_free(usb_multimedia_t **multim_dev)
-{
-        if (multim_dev == NULL || *multim_dev == NULL) {
-                return;
-        }
-        
-        // hangup phone to the console
-        async_obsolete_hangup((*multim_dev)->console_phone);
-
-        free(*multim_dev);
-        *multim_dev = NULL;
-}
-
-/*----------------------------------------------------------------------------*/
-
 static int usb_multimedia_create_function(usb_hid_dev_t *hid_dev, 
     usb_multimedia_t *multim_dev)
@@ -247 +232 @@
         
         int rc = usb_multimedia_create_function(hid_dev, multim_dev);
-        if (rc != EOK) {
-                usb_multimedia_free(&multim_dev);
+        if (rc != EOK)
                 return rc;
-        }
         
         usb_log_debug(NAME " HID/multimedia structure initialized.\n");
@@ -267 +250 @@
         if (data != NULL) {
                 usb_multimedia_t *multim_dev = (usb_multimedia_t *)data;
-                usb_multimedia_free(&multim_dev);
+                // hangup phone to the console
+                async_obsolete_hangup(multim_dev->console_phone);
         }
 }