Changeset 5f6e25e in mainline for uspace/drv/bus/usb/usbhid/mouse/mousedev.c

Timestamp:

2011-08-29T23:00:12Z (13 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

58cbb0c8

Parents:

c5be39b

Message:

Leave it up to DDF to free driver-specific data. This makes it possible
to ensure soft state is not freed during calls to driver entry points.

This requires some driver changes:

• minimum change is not to free() driver-data structures (ddf_fun_t.driver_data and ddf_dev_t.driver_data)
• ideally allocate using ddf_dev_data_alloc(), ddf_fun_data_alloc()

I tried fixing existing drivers accordingly (mostly the minimalistic
change variant), but could have missed something.

File:

• uspace/drv/bus/usb/usbhid/mouse/mousedev.c (modified) (3 diffs)

uspace/drv/bus/usb/usbhid/mouse/mousedev.c

@@ -183 +183 @@
 /*----------------------------------------------------------------------------*/
 
-static void usb_mouse_free(usb_mouse_t **mouse_dev)
-{
-        assert(mouse_dev != NULL && *mouse_dev != NULL);
+static void usb_mouse_destroy(usb_mouse_t *mouse_dev)
+{
+        assert(mouse_dev != NULL);
         
         // hangup phone to the console
-        if ((*mouse_dev)->mouse_phone >= 0) {
-                async_obsolete_hangup((*mouse_dev)->mouse_phone);
-        }
-        
-        if ((*mouse_dev)->wheel_phone >= 0) {
-                async_obsolete_hangup((*mouse_dev)->wheel_phone);
-        }
-        
-        free(*mouse_dev);
-        *mouse_dev = NULL;
+        if (mouse_dev->mouse_phone >= 0) {
+                async_obsolete_hangup(mouse_dev->mouse_phone);
+        }
+        
+        if (mouse_dev->wheel_phone >= 0) {
+                async_obsolete_hangup(mouse_dev->wheel_phone);
+        }
 }
 
@@ -437 +434 @@
         int rc = usb_mouse_create_function(hid_dev, mouse_dev);
         if (rc != EOK) {
-                usb_mouse_free(&mouse_dev);
+                usb_mouse_destroy(mouse_dev);
                 return rc;
         }
@@ -464 +461 @@
 {
         if (data != NULL) {
-                usb_mouse_free((usb_mouse_t **)&data);
+                usb_mouse_destroy((usb_mouse_t *)data);
         }
 }