Changeset 5f6e25e in mainline for uspace/drv/bus/usb/usbhid/main.c

Timestamp:

2011-08-29T23:00:12Z (13 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

58cbb0c8

Parents:

c5be39b

Message:

Leave it up to DDF to free driver-specific data. This makes it possible
to ensure soft state is not freed during calls to driver entry points.

This requires some driver changes:

• minimum change is not to free() driver-data structures (ddf_fun_t.driver_data and ddf_dev_t.driver_data)
• ideally allocate using ddf_dev_data_alloc(), ddf_fun_data_alloc()

I tried fixing existing drivers accordingly (mostly the minimalistic
change variant), but could have missed something.

File:

• uspace/drv/bus/usb/usbhid/main.c (modified) (1 diff)

uspace/drv/bus/usb/usbhid/main.c

@@ -93 +93 @@
         if (rc != EOK) {
                 usb_log_error("Failed to initialize USB/HID device.\n");
-                usb_hid_free(&hid_dev);
+                usb_hid_destroy(hid_dev);
                 return rc;
         }