Changeset 5f6e25e in mainline for uspace/drv/bus/usb/usbhid/kbd/kbddev.c

Timestamp:

2011-08-29T23:00:12Z (13 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

58cbb0c8

Parents:

c5be39b

Message:

Leave it up to DDF to free driver-specific data. This makes it possible
to ensure soft state is not freed during calls to driver entry points.

This requires some driver changes:

• minimum change is not to free() driver-data structures (ddf_fun_t.driver_data and ddf_dev_t.driver_data)
• ideally allocate using ddf_dev_data_alloc(), ddf_fun_data_alloc()

I tried fixing existing drivers accordingly (mostly the minimalistic
change variant), but could have missed something.

File:

• uspace/drv/bus/usb/usbhid/kbd/kbddev.c (modified) (3 diffs)

uspace/drv/bus/usb/usbhid/kbd/kbddev.c

@@ -734 +734 @@
         int rc = usb_kbd_create_function(hid_dev, kbd_dev);
         if (rc != EOK) {
-                usb_kbd_free(&kbd_dev);
+                usb_kbd_destroy(kbd_dev);
                 return rc;
         }
@@ -779 +779 @@
  * @param kbd_dev Pointer to the structure to be destroyed.
  */
-void usb_kbd_free(usb_kbd_t **kbd_dev)
-{
-        if (kbd_dev == NULL || *kbd_dev == NULL) {
+void usb_kbd_destroy(usb_kbd_t *kbd_dev)
+{
+        if (kbd_dev == NULL) {
                 return;
         }
         
         // hangup phone to the console
-        async_obsolete_hangup((*kbd_dev)->console_phone);
-        
-        if ((*kbd_dev)->repeat_mtx != NULL) {
+        async_obsolete_hangup(kbd_dev->console_phone);
+        
+        if (kbd_dev->repeat_mtx != NULL) {
                 //assert(!fibril_mutex_is_locked((*kbd_dev)->repeat_mtx));
                 // FIXME - the fibril_mutex_is_locked may not cause
                 // fibril scheduling
-                while (fibril_mutex_is_locked((*kbd_dev)->repeat_mtx)) {}
-                free((*kbd_dev)->repeat_mtx);
+                while (fibril_mutex_is_locked(kbd_dev->repeat_mtx)) {}
+                free(kbd_dev->repeat_mtx);
         }
         
         // free all buffers
-        if ((*kbd_dev)->keys != NULL) {
-                free((*kbd_dev)->keys);
-        }
-        if ((*kbd_dev)->keys_old != NULL) {
-                free((*kbd_dev)->keys_old);
-        }
-        if ((*kbd_dev)->led_data != NULL) {
-                free((*kbd_dev)->led_data);
-        }
-        if ((*kbd_dev)->led_path != NULL) {
-                usb_hid_report_path_free((*kbd_dev)->led_path);
-        }
-        if ((*kbd_dev)->output_buffer != NULL) {
-                usb_hid_report_output_free((*kbd_dev)->output_buffer);
-        }
-
-        free(*kbd_dev);
-        *kbd_dev = NULL;
+        if (kbd_dev->keys != NULL) {
+                free(kbd_dev->keys);
+        }
+        if (kbd_dev->keys_old != NULL) {
+                free(kbd_dev->keys_old);
+        }
+        if (kbd_dev->led_data != NULL) {
+                free(kbd_dev->led_data);
+        }
+        if (kbd_dev->led_path != NULL) {
+                usb_hid_report_path_free(kbd_dev->led_path);
+        }
+        if (kbd_dev->output_buffer != NULL) {
+                usb_hid_report_output_free(kbd_dev->output_buffer);
+        }
 }
 
@@ -830 +827 @@
                         usb_kbd_mark_unusable(kbd_dev);
                 } else {
-                        usb_kbd_free(&kbd_dev);
+                        usb_kbd_destroy(kbd_dev);
                 }
         }