Changeset 5823aef3 in mainline

Timestamp:

2021-06-10T13:22:33Z (3 years ago)

Author:

jxsvoboda <5887334+jxsvoboda@…>

Branches:

master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d7f82635

Parents:

9e84d2c

git-author:

Jiri Svoboda <jiri@…> (2021-06-03 17:03:11)

git-committer:

jxsvoboda <5887334+jxsvoboda@…> (2021-06-10 13:22:33)

Message:

Fix delivery of release events to popup window

File:

• uspace/srv/hid/display/seat.c (modified) (2 diffs)

uspace/srv/hid/display/seat.c

@@ -432 +432 @@
          * below, anyway.
          */
-        if (seat->popup != wnd && seat->popup != NULL) {
+        if (seat->popup != NULL) {
                 rc = ds_window_post_pos_event(seat->popup, event);
                 if (rc != EOK)
@@ -452 +452 @@
                 ds_seat_set_client_cursor(seat, wnd->cursor);
 
-                rc = ds_window_post_pos_event(wnd, event);
-                if (rc != EOK)
-                        return rc;
+                /*
+                 * Only deliver event if we didn't already deliver it
+                 * to the same window above.
+                 */
+                if (wnd != seat->popup) {
+                        rc = ds_window_post_pos_event(wnd, event);
+                        if (rc != EOK)
+                                return rc;
+                }
         } else {
                 /* Not over a window */