Changeset 5667dca in mainline for kernel/generic/src/udebug/udebug.c

Timestamp:

2019-10-02T12:36:33Z (5 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0a201454

Parents:

9dcf472

git-author:

Jiri Svoboda <jiri@…> (2019-10-01 18:38:27)

git-committer:

Jiri Svoboda <jiri@…> (2019-10-02 12:36:33)

Message:

Do not block faulted task until debugger exits

If a task faults while a debugger (such as trace) is attached, we must
not block the task until the debugger exits (trace waits for task to
exit). It is sufficient to wait for a debugger to start, because
the task gets blocked in udebug_stoppable_end() (since the task is
not GO).

File:

• kernel/generic/src/udebug/udebug.c (modified) (1 diff)

kernel/generic/src/udebug/udebug.c

@@ -479 +479 @@
         mutex_unlock(&THREAD->udebug.lock);
 
-        /* Make sure the debugging session is over before proceeding. */
-        mutex_lock(&THREAD->udebug.lock);
-        while (THREAD->udebug.active)
-                condvar_wait(&THREAD->udebug.active_cv, &THREAD->udebug.lock);
-        mutex_unlock(&THREAD->udebug.lock);
-
+        /*
+         * This is where we will typically block until a post-mortem debugger
+         * terminates the debugging session.
+         */
         udebug_stoppable_end();
 }