Changeset 562a48b in mainline

Timestamp:

2016-03-16T10:21:23Z (8 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

479cc46

Parents:

722bb5a

git-author:

Manuele Conti <conti.manuele@…> (2016-03-16 10:21:23)

git-committer:

Jakub Jermar <jakub@…> (2016-03-16 10:21:23)

Message:

Fix a memory leak in error path in driver_dev_add().

File:

• uspace/lib/drv/generic/driver.c (modified) (2 diffs)

uspace/lib/drv/generic/driver.c

@@ -121 +121 @@
         devman_handle_t parent_fun_handle = IPC_GET_ARG2(*icall);
         
-        ddf_dev_t *dev = create_device();
-        
-        /* Add one reference that will be dropped by driver_dev_remove() */
-        dev_add_ref(dev);
-        dev->handle = dev_handle;
-        
         char *dev_name = NULL;
         int rc = async_data_write_accept((void **) &dev_name, true, 0, 0, 0, 0);
@@ -133 +127 @@
                 return;
         }
-        
+
+        ddf_dev_t *dev = create_device();
+
+        /* Add one reference that will be dropped by driver_dev_remove() */
+        dev_add_ref(dev);
+        dev->handle = dev_handle;
         dev->name = dev_name;