Changeset 548c123 in mainline for uspace/drv/bus/usb/xhci/commands.h

Timestamp:

2017-09-29T21:46:08Z (7 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

cc9ac7c

Parents:

ab5a0830

Message:

xhci commands: embed TRB into the command structure

Previously, a pointer into the TRB ring itself was contained. That could cause
problems, because the ring does not care and can move/deallocate segments, or
overwrite TRBs inside. To solve the original issue, xhci_trb_ring_enqueue can
now fill physical address of the TRB enqueued.

Also, this eliminates the need to track ownage of TRB.

File:

• uspace/drv/bus/usb/xhci/commands.h (modified) (2 diffs)

uspace/drv/bus/usb/xhci/commands.h

@@ -39 +39 @@
 #include <adt/list.h>
 #include <stdbool.h>
+#include "hw_struct/trb.h"
 
 typedef struct xhci_hc xhci_hc_t;
-typedef struct xhci_trb xhci_trb_t;
 typedef struct xhci_input_ctx xhci_input_ctx_t;
 
@@ -47 +47 @@
         link_t link;
 
-        xhci_trb_t *trb;
+        xhci_trb_t trb;
+        uintptr_t trb_phys;
         xhci_input_ctx_t *ictx;
         uint32_t slot_id;