Changeset 514d561 in mainline for uspace/lib/c/generic/rcu.c

Timestamp:

2018-07-20T16:27:20Z (6 years ago)

Author:

Jiří Zárevúcky <jiri.zarevucky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

05208d9

Parents:

7137f74c

git-author:

Jiří Zárevúcky <jiri.zarevucky@…> (2018-07-19 21:52:47)

git-committer:

Jiří Zárevúcky <jiri.zarevucky@…> (2018-07-20 16:27:20)

Message:

Fibril/async implementation overhaul.

This commit marks the move towards treating the fibril library as a mere
implementation of a generic threading interface. Understood as a layer that
wraps the kernel threads, we not only have to wrap threading itself, but also
every syscall that blocks the kernel thread (by blocking, we mean thread not
doing useful work until an external event happens — e.g. locking a kernel
mutex or thread sleep is understood as blocking, but an as_area_create() is not,
despite potentially taking a long time to complete).

Consequently, we implement fibril_ipc_wait() as a fibril-native wrapper for
kernel's ipc_wait(), and also implement timer functionality like timeouts
as part of the fibril library. This removes the interdependency between fibril
implementation and the async framework — in theory, the fibril API could be
reimplemented as a simple 1:1 shim, and the async framework would continue
working normally (note that the current implementation of loader complicates
this).

To better isolate the fibril internals from the implementation of high-level
synchronization, a fibril_event_t is added. This object conceptually acts
like a single slot wait queue. All other synchronization is implemented in
terms of this primitive.

File:

• uspace/lib/c/generic/rcu.c (modified) (5 diffs)

uspace/lib/c/generic/rcu.c

@@ -115 +115 @@
 
 typedef struct blocked_fibril {
-        fid_t id;
+        fibril_event_t unblock;
         link_t link;
         bool is_ready;
@@ -218 +218 @@
 }
 
-/** Delimits the start of an RCU reader critical section. */
+/** Delimits the end of an RCU reader critical section. */
 void rcu_read_unlock(void)
 {
@@ -361 +361 @@
         if (rcu.sync_lock.locked) {
                 blocked_fibril_t blocked_fib;
-                blocked_fib.id = fibril_get_id();
+                blocked_fib.unblock = FIBRIL_EVENT_INIT;
 
                 list_append(&blocked_fib.link, &rcu.sync_lock.blocked_fibrils);
@@ -368 +368 @@
                         blocked_fib.is_ready = false;
                         fibril_rmutex_unlock(&rcu.sync_lock.mutex);
-                        futex_lock(&async_futex);
-                        fibril_switch(FIBRIL_FROM_BLOCKED);
-                        futex_unlock(&async_futex);
+                        fibril_wait_for(&blocked_fib.unblock);
                         fibril_rmutex_lock(&rcu.sync_lock.mutex);
                 } while (rcu.sync_lock.locked);
@@ -393 +391 @@
                 if (!blocked_fib->is_ready) {
                         blocked_fib->is_ready = true;
-                        fibril_add_ready(blocked_fib->id);
+                        fibril_notify(&blocked_fib->unblock);
                 }
         }