Changeset 4e8e1f5 in mainline

Timestamp:

2011-02-11T18:10:21Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d321cd7

Parents:

79d2987

Message:

Device recognition uses pipe API

Location:

uspace

Files:

• app/usbinfo/info.c (modified) (4 diffs)
• drv/uhci-rhd/port.c (modified) (2 diffs)
• drv/usbhub/usbhub.c (modified) (2 diffs)
• drv/vhc/hub.c (modified) (2 diffs)
• lib/usb/include/usb/recognise.h (added)
• lib/usb/include/usb/usbdrv.h (modified) (1 diff)
• lib/usb/src/recognise.c (modified) (12 diffs)

uspace/app/usbinfo/info.c

@@ -39 +39 @@
 #include <usb/usbdrv.h>
 #include <usb/pipes.h>
+#include <usb/recognise.h>
 #include <usb/request.h>
 #include "usbinfo.h"
@@ -47 +48 @@
         usb_device_connection_t wire;
         usb_endpoint_pipe_t ctrl_pipe;
-        ctrl_pipe.hc_phone = -1;
-
-        int hc_phone = devman_device_connect(hc_handle, 0);
-        if (hc_phone < 0) {
-                fprintf(stderr,
-                    NAME ": failed to connect to host controller (%zu): %s.\n",
-                        (size_t) hc_handle, str_error(hc_phone));
-                return hc_phone;
-        }
-
-        /*
-         * Dump information about possible match ids.
-         */
-        match_id_list_t match_id_list;
-        init_match_ids(&match_id_list);
-        rc = usb_drv_create_device_match_ids(hc_phone, &match_id_list, address);
-        if (rc != EOK) {
-                fprintf(stderr,
-                    NAME ": failed to fetch match ids of the device: %s.\n",
-                    str_error(rc));
-                goto leave;
-        }
-        dump_match_ids(&match_id_list);
 
         /*
@@ -95 +73 @@
                 goto leave;
         }
+
+        /*
+         * Dump information about possible match ids.
+         */
+        match_id_list_t match_id_list;
+        init_match_ids(&match_id_list);
+        rc = usb_device_create_match_ids(&ctrl_pipe, &match_id_list);
+        if (rc != EOK) {
+                fprintf(stderr,
+                    NAME ": failed to fetch match ids of the device: %s.\n",
+                    str_error(rc));
+                goto leave;
+        }
+        dump_match_ids(&match_id_list);
 
         /*
@@ -141 +133 @@
 leave:
         /* Ignoring errors here. */
-        async_hangup(hc_phone);
         usb_endpoint_pipe_end_session(&ctrl_pipe);
 

uspace/drv/uhci-rhd/port.c

@@ -33 +33 @@
  */
 #include <errno.h>
+#include <str_error.h>
 
 #include <usb/usb.h>    /* usb_address_t */
 #include <usb/usbdrv.h> /* usb_drv_*     */
 #include <usb/debug.h>
+#include <usb/recognise.h>
 
 #include "port.h"
@@ -204 +206 @@
         assert(port->attached_device == 0);
 
-        ret = usb_drv_register_child_in_devman(port->hc_phone, port->rh,
-          usb_address, &port->attached_device);
-
+        devman_handle_t hc_handle;
+        ret = usb_drv_find_hc(port->rh, &hc_handle);
+        if (ret != EOK) {
+                usb_log_error("Failed to get handle of host controller: %s.\n",
+                    str_error(ret));
+                uhci_port_set_enabled(port, false);
+                return ENOMEM;
+        }
+
+        ret = usb_device_register_child_in_devman(usb_address, hc_handle,
+            port->rh, &port->attached_device);
         if (ret != EOK) { /* something went wrong */
                 usb_log_error("Failed(%d) in usb_drv_register_child.\n", ret);

uspace/drv/usbhub/usbhub.c

@@ -36 +36 @@
 #include <bool.h>
 #include <errno.h>
+#include <str_error.h>
 
 #include <usb_iface.h>
 #include <usb/usbdrv.h>
 #include <usb/descriptor.h>
+#include <usb/recognise.h>
 #include <usb/devreq.h>
 #include <usb/classes/hub.h>
@@ -317 +319 @@
         }
 
+        devman_handle_t hc_handle;
+        opResult = usb_drv_find_hc(hub->device, &hc_handle);
+        if (opResult != EOK) {
+                usb_log_error("Failed to get handle of host controller: %s.\n",
+                    str_error(opResult));
+                return;
+        }
+
         devman_handle_t child_handle;
-        opResult = usb_drv_register_child_in_devman(hc, hub->device,
-            new_device_address, &child_handle);
+        opResult = usb_device_register_child_in_devman(new_device_address,
+            hc_handle, hub->device, &child_handle);
         if (opResult != EOK) {
                 dprintf(USB_LOG_LEVEL_ERROR, "could not start driver for new device");

uspace/drv/vhc/hub.c

@@ -41 +41 @@
 #include <driver.h>
 #include <usb/usbdrv.h>
+#include <usb/recognise.h>
 
 #include "hub.h"
@@ -93 +94 @@
 
         devman_handle_t hub_handle;
-        usb_drv_register_child_in_devman(hc, hc_dev, hub_address, &hub_handle);
+        usb_device_register_child_in_devman(hub_address, hc_dev->handle,
+            hc_dev, &hub_handle);
+        //usb_drv_register_child_in_devman(hc, hc_dev, hub_address, &hub_handle);
         usb_drv_bind_address(hc, hub_address, hub_handle);
 

uspace/lib/usb/include/usb/usbdrv.h

@@ -106 +106 @@
     const void *, size_t);
 
-int usb_drv_create_device_match_ids(int, match_id_list_t *, usb_address_t);
-int usb_drv_register_child_in_devman(int, device_t *, usb_address_t,
-    devman_handle_t *);
-
 
 #endif

uspace/lib/usb/src/recognise.c

@@ -36 +36 @@
 #include <usb_iface.h>
 #include <usb/usbdrv.h>
+#include <usb/pipes.h>
+#include <usb/recognise.h>
+#include <usb/request.h>
 #include <usb/classes/classes.h>
 #include <stdio.h>
 #include <errno.h>
+
+static size_t device_name_index = 0;
+static FIBRIL_MUTEX_INITIALIZE(device_name_index_mutex);
 
 /** Callback for getting host controller handle.
@@ -241 +247 @@
 /** Add match ids based on configuration descriptor.
  *
- * @param hc Open phone to host controller.
+ * @param pipe Control pipe to the device.
  * @param matches Match ids list to add matches to.
- * @param address USB address of the attached device.
  * @param config_count Number of configurations the device has.
  * @return Error code.
  */
-static int usb_add_config_descriptor_match_ids(int hc,
-    match_id_list_t *matches, usb_address_t address,
-    int config_count)
+static int usb_add_config_descriptor_match_ids(usb_endpoint_pipe_t *pipe,
+    match_id_list_t *matches, int config_count)
 {
         int final_rc = EOK;
@@ -257 +261 @@
                 int rc;
                 usb_standard_configuration_descriptor_t config_descriptor;
-                rc = usb_drv_req_get_bare_configuration_descriptor(hc,
-                    address,  config_index, &config_descriptor);
+                rc = usb_request_get_bare_configuration_descriptor(pipe,
+                    config_index, &config_descriptor);
                 if (rc != EOK) {
                         final_rc = rc;
@@ -267 +271 @@
                 void *full_config_descriptor
                     = malloc(config_descriptor.total_length);
-                rc = usb_drv_req_get_full_configuration_descriptor(hc,
-                    address, config_index,
+                rc = usb_request_get_full_configuration_descriptor(pipe,
+                    config_index,
                     full_config_descriptor, config_descriptor.total_length,
                     &full_config_descriptor_size);
@@ -299 +303 @@
  * function exits with error.
  *
- * @param hc Open phone to host controller.
+ * @param ctrl_pipe Control pipe to given device (session must be already
+ *      started).
  * @param matches Initialized list of match ids.
- * @param address USB address of the attached device.
- * @return Error code.
- */
-int usb_drv_create_device_match_ids(int hc, match_id_list_t *matches,
-    usb_address_t address)
+ * @return Error code.
+ */
+int usb_device_create_match_ids(usb_endpoint_pipe_t *ctrl_pipe,
+    match_id_list_t *matches)
 {
         int rc;
-        
         /*
          * Retrieve device descriptor and add matches from it.
@@ -314 +317 @@
         usb_standard_device_descriptor_t device_descriptor;
 
-        rc = usb_drv_req_get_device_descriptor(hc, address,
-            &device_descriptor);
+        rc = usb_request_get_device_descriptor(ctrl_pipe, &device_descriptor);
         if (rc != EOK) {
                 return rc;
         }
-        
+
         rc = usb_drv_create_match_ids_from_device_descriptor(matches,
             &device_descriptor);
@@ -325 +327 @@
                 return rc;
         }
-        
+
         /*
          * Go through all configurations and add matches
          * based on interface class.
          */
-        rc = usb_add_config_descriptor_match_ids(hc, matches,
-            address, device_descriptor.configuration_count);
+        rc = usb_add_config_descriptor_match_ids(ctrl_pipe, matches,
+            device_descriptor.configuration_count);
         if (rc != EOK) {
                 return rc;
@@ -347 +349 @@
 }
 
-
 /** Probe for device kind and register it in devman.
  *
- * @param[in] hc Open phone to the host controller.
+ * @param[in] address Address of the (unknown) attached device.
+ * @param[in] hc_handle Handle of the host controller.
  * @param[in] parent Parent device.
- * @param[in] address Address of the (unknown) attached device.
  * @param[out] child_handle Handle of the child device.
  * @return Error code.
  */
-int usb_drv_register_child_in_devman(int hc, device_t *parent,
-    usb_address_t address, devman_handle_t *child_handle)
-{
-        static size_t device_name_index = 0;
-        static FIBRIL_MUTEX_INITIALIZE(device_name_index_mutex);
-
+int usb_device_register_child_in_devman(usb_address_t address,
+    devman_handle_t hc_handle,
+    device_t *parent, devman_handle_t *child_handle)
+{
         size_t this_device_name_index;
 
@@ -369 +368 @@
         fibril_mutex_unlock(&device_name_index_mutex);
 
-
         device_t *child = NULL;
         char *child_name = NULL;
         int rc;
+        usb_device_connection_t dev_connection;
+        usb_endpoint_pipe_t ctrl_pipe;
+
+        rc = usb_device_connection_initialize(&dev_connection, hc_handle, address);
+        if (rc != EOK) {
+                goto failure;
+        }
+
+        rc = usb_endpoint_pipe_initialize_default_control(&ctrl_pipe,
+            &dev_connection);
+        if (rc != EOK) {
+                goto failure;
+        }
 
         child = create_device();
@@ -391 +402 @@
         child->name = child_name;
         child->ops = &child_ops;
-        
-        rc = usb_drv_create_device_match_ids(hc, &child->match_ids, address);
+
+        rc = usb_endpoint_pipe_start_session(&ctrl_pipe);
+        if (rc != EOK) {
+                goto failure;
+        }
+
+        rc = usb_device_create_match_ids(&ctrl_pipe, &child->match_ids);
+        if (rc != EOK) {
+                goto failure;
+        }
+
+        rc = usb_endpoint_pipe_end_session(&ctrl_pipe);
         if (rc != EOK) {
                 goto failure;
@@ -405 +426 @@
                 *child_handle = child->handle;
         }
-        
+
         return EOK;
 
@@ -419 +440 @@
 
         return rc;
-
 }