Changeset 48bcf49 in mainline for kernel/generic/src/ipc/ops/stchngath.c

Timestamp:

2017-09-28T22:08:15Z (7 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

6636fb19

Parents:

dd20cbb

Message:

Introduce reference-counted kobjects

Capabilities are thus reduced to task-local names for references to kobjects.

File:

• kernel/generic/src/ipc/ops/stchngath.c (modified) (3 diffs)

kernel/generic/src/ipc/ops/stchngath.c

@@ -45 +45 @@
         task_t *other_task_s;
 
-        phone_t *sender_phone = phone_get_current(IPC_GET_ARG5(call->data));
-        if (!sender_phone)
+        kobject_t *sender_obj = kobject_get(TASK, IPC_GET_ARG5(call->data),
+            KOBJECT_TYPE_PHONE);
+        if (!sender_obj)
                 return ENOENT;
 
-        mutex_lock(&sender_phone->lock);
-        if (sender_phone->state != IPC_PHONE_CONNECTED) {
-                mutex_unlock(&sender_phone->lock);
+        mutex_lock(&sender_obj->phone->lock);
+        if (sender_obj->phone->state != IPC_PHONE_CONNECTED) {
+                mutex_unlock(&sender_obj->phone->lock);
+                kobject_put(sender_obj);
                 return EINVAL;
         }
 
-        other_task_s = sender_phone->callee->task;
+        other_task_s = sender_obj->phone->callee->task;
 
-        mutex_unlock(&sender_phone->lock);
+        mutex_unlock(&sender_obj->phone->lock);
 
         /* Remember the third party task hash. */
         IPC_SET_ARG5(call->data, (sysarg_t) other_task_s);
 
+        kobject_put(sender_obj);
         return EOK;
 }
@@ -71 +74 @@
         if (!IPC_GET_RETVAL(answer->data)) {
                 /* The recipient authorized the change of state. */
-                phone_t *recipient_phone;
                 task_t *other_task_s;
                 task_t *other_task_r;
 
-                recipient_phone = phone_get_current(IPC_GET_ARG1(answer->data));
-                if (!recipient_phone) {
+                kobject_t *recipient_obj = kobject_get(TASK,
+                    IPC_GET_ARG1(answer->data), KOBJECT_TYPE_PHONE);
+                if (!recipient_obj) {
                         IPC_SET_RETVAL(answer->data, ENOENT);
                         return ENOENT;
                 }
 
-                mutex_lock(&recipient_phone->lock);
-                if (recipient_phone->state != IPC_PHONE_CONNECTED) {
-                        mutex_unlock(&recipient_phone->lock);
+                mutex_lock(&recipient_obj->phone->lock);
+                if (recipient_obj->phone->state != IPC_PHONE_CONNECTED) {
+                        mutex_unlock(&recipient_obj->phone->lock);
                         IPC_SET_RETVAL(answer->data, EINVAL);
+                        kobject_put(recipient_obj);
                         return EINVAL;
                 }
 
-                other_task_r = recipient_phone->callee->task;
+                other_task_r = recipient_obj->phone->callee->task;
                 other_task_s = (task_t *) IPC_GET_ARG5(*olddata);
 
@@ -109 +113 @@
                 }
 
-                mutex_unlock(&recipient_phone->lock);
+                mutex_unlock(&recipient_obj->phone->lock);
+                kobject_put(recipient_obj);
         }