Changeset 46b881c in mainline for uspace/srv/hw/irc/apic/apic.c


Ignore:
Timestamp:
2011-01-29T11:36:41Z (13 years ago)
Author:
Martin Decky <martin@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
0b6931a, 8add9ca5
Parents:
e26a4633 (diff), ffa2c8ef (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.
Message:

IPC/async: strictly isolate the use of low-level IPC methods (ipc_*) and async framework methods (async_*) in user code, do not allow a mixture of both in a single source file

Benefits for future plans

  • The async framework could use different communication style under the hood, but keeping the same high-level API
  • The async framework can be integrated more tightly with sessions without potential problems of intermixing session-aware async methods with session-unaware low-level methods in user code
  • The async_serialize_start()/_end() can be deprecated more easily
File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/srv/hw/irc/apic/apic.c

    re26a4633 r46b881c  
    3636 */
    3737
    38 #include <ipc/ipc.h>
    3938#include <ipc/services.h>
    4039#include <ipc/irc.h>
     
    7574         * Answer the first IPC_M_CONNECT_ME_TO call.
    7675         */
    77         ipc_answer_0(iid, EOK);
     76        async_answer_0(iid, EOK);
    7877       
    7978        while (true) {
     
    8281                switch (IPC_GET_IMETHOD(call)) {
    8382                case IRC_ENABLE_INTERRUPT:
    84                         ipc_answer_0(callid, apic_enable_irq(IPC_GET_ARG1(call)));
     83                        async_answer_0(callid, apic_enable_irq(IPC_GET_ARG1(call)));
    8584                        break;
    8685                case IRC_CLEAR_INTERRUPT:
    8786                        /* Noop */
    88                         ipc_answer_0(callid, EOK);
     87                        async_answer_0(callid, EOK);
    8988                        break;
    9089                default:
    91                         ipc_answer_0(callid, EINVAL);
     90                        async_answer_0(callid, EINVAL);
    9291                        break;
    9392                }
Note: See TracChangeset for help on using the changeset viewer.