Changeset 46b881c in mainline for uspace/srv/hid/console/console.c

Timestamp:

2011-01-29T11:36:41Z (13 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0b6931a, 8add9ca5

Parents:

e26a4633 (diff), ffa2c8ef (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

IPC/async: strictly isolate the use of low-level IPC methods (ipc_*) and async framework methods (async_*) in user code, do not allow a mixture of both in a single source file

Benefits for future plans

• The async framework could use different communication style under the hood, but keeping the same high-level API
• The async framework can be integrated more tightly with sessions without potential problems of intermixing session-aware async methods with session-unaware low-level methods in user code
• The async_serialize_start()/_end() can be deprecated more easily

File:

• uspace/srv/hid/console/console.c (modified) (18 diffs)

uspace/srv/hid/console/console.c

@@ -34 +34 @@
 
 #include <libc.h>
-#include <ipc/ipc.h>
 #include <ipc/kbd.h>
 #include <io/keycode.h>
@@ -117 +116 @@
 static void curs_hide_sync(void)
 {
-        ipc_call_sync_1_0(fb_info.phone, FB_CURSOR_VISIBILITY, false); 
+        async_req_1_0(fb_info.phone, FB_CURSOR_VISIBILITY, false); 
 }
 
@@ -132 +131 @@
 static void screen_yield(void)
 {
-        ipc_call_sync_0_0(fb_info.phone, FB_SCREEN_YIELD);
+        async_req_0_0(fb_info.phone, FB_SCREEN_YIELD);
 }
 
 static void screen_reclaim(void)
 {
-        ipc_call_sync_0_0(fb_info.phone, FB_SCREEN_RECLAIM);
+        async_req_0_0(fb_info.phone, FB_SCREEN_RECLAIM);
 }
 
 static void kbd_yield(void)
 {
-        ipc_call_sync_0_0(kbd_phone, KBD_YIELD);
+        async_req_0_0(kbd_phone, KBD_YIELD);
 }
 
 static void kbd_reclaim(void)
 {
-        ipc_call_sync_0_0(kbd_phone, KBD_RECLAIM);
+        async_req_0_0(kbd_phone, KBD_RECLAIM);
 }
 
@@ -438 +437 @@
                         retval = ENOENT;
                 }
-                ipc_answer_0(callid, retval);
+                async_answer_0(callid, retval);
         }
 }
@@ -473 +472 @@
                 }
 
-                ipc_answer_0(callid, retval);
+                async_answer_0(callid, retval);
         }
 }
@@ -484 +483 @@
         
         if (rc != EOK) {
-                ipc_answer_0(rid, rc);
+                async_answer_0(rid, rc);
                 return;
         }
@@ -499 +498 @@
         
         gcons_notify_char(cons->index);
-        ipc_answer_1(rid, EOK, size);
+        async_answer_1(rid, EOK, size);
         
         free(buf);
@@ -509 +508 @@
         size_t size;
         if (!async_data_read_receive(&callid, &size)) {
-                ipc_answer_0(callid, EINVAL);
-                ipc_answer_0(rid, EINVAL);
+                async_answer_0(callid, EINVAL);
+                async_answer_0(rid, EINVAL);
                 return;
         }
@@ -516 +515 @@
         char *buf = (char *) malloc(size);
         if (buf == NULL) {
-                ipc_answer_0(callid, ENOMEM);
-                ipc_answer_0(rid, ENOMEM);
+                async_answer_0(callid, ENOMEM);
+                async_answer_0(rid, ENOMEM);
                 return;
         }
@@ -535 +534 @@
         if (pos == size) {
                 (void) async_data_read_finalize(callid, buf, size);
-                ipc_answer_1(rid, EOK, size);
+                async_answer_1(rid, EOK, size);
                 free(buf);
         } else {
@@ -553 +552 @@
 recheck:
         if (keybuffer_pop(&cons->keybuffer, &ev)) {
-                ipc_answer_4(rid, EOK, ev.type, ev.key, ev.mods, ev.c);
+                async_answer_4(rid, EOK, ev.type, ev.key, ev.mods, ev.c);
         } else {
                 fibril_condvar_wait(&input_cv, &input_mutex);
@@ -579 +578 @@
         
         if (cons == NULL) {
-                ipc_answer_0(iid, ENOENT);
+                async_answer_0(iid, ENOENT);
                 return;
         }
@@ -598 +597 @@
         
         /* Accept the connection */
-        ipc_answer_0(iid, EOK);
+        async_answer_0(iid, EOK);
         
         while (true) {
@@ -658 +657 @@
                         rc = ccap_fb_to_con(fb_info.color_cap, &arg1);
                         if (rc != EOK) {
-                                ipc_answer_0(callid, rc);
+                                async_answer_0(callid, rc);
                                 continue;
                         }
@@ -702 +701 @@
                         break;
                 }
-                ipc_answer_3(callid, EOK, arg1, arg2, arg3);
+                async_answer_3(callid, EOK, arg1, arg2, arg3);
         }
 }
@@ -727 +726 @@
         
         /* NB: The callback connection is slotted for removal */
-        sysarg_t taskhash;
-        sysarg_t phonehash;
-        if (ipc_connect_to_me(kbd_phone, SERVICE_CONSOLE, 0, 0, &taskhash,
-            &phonehash) != 0) {
+        if (async_connect_to_me(kbd_phone, SERVICE_CONSOLE, 0, 0, keyboard_events)
+            != 0) {
                 printf(NAME ": Failed to create callback from input device\n");
                 return false;
         }
-        
-        async_new_connection(taskhash, phonehash, 0, NULL, keyboard_events);
         
         /* Connect to mouse device */
@@ -752 +747 @@
         }
         
-        if (ipc_connect_to_me(mouse_phone, SERVICE_CONSOLE, 0, 0, &taskhash,
-            &phonehash) != 0) {
+        if (async_connect_to_me(mouse_phone, SERVICE_CONSOLE, 0, 0, mouse_events)
+            != 0) {
                 printf(NAME ": Failed to create callback from mouse device\n");
                 mouse_phone = -1;
@@ -759 +754 @@
         }
         
-        async_new_connection(taskhash, phonehash, 0, NULL, mouse_events);
 skip_mouse: