Changeset 46b881c in mainline for uspace/srv/hid/adb_mouse/adb_dev.c

Timestamp:

2011-01-29T11:36:41Z (13 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0b6931a, 8add9ca5

Parents:

e26a4633 (diff), ffa2c8ef (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

IPC/async: strictly isolate the use of low-level IPC methods (ipc_*) and async framework methods (async_*) in user code, do not allow a mixture of both in a single source file

Benefits for future plans

• The async framework could use different communication style under the hood, but keeping the same high-level API
• The async framework can be integrated more tightly with sessions without potential problems of intermixing session-aware async methods with session-unaware low-level methods in user code
• The async_serialize_start()/_end() can be deprecated more easily

File:

• uspace/srv/hid/adb_mouse/adb_dev.c (modified) (3 diffs)

uspace/srv/hid/adb_mouse/adb_dev.c

@@ -34 +34 @@
  */
 
-#include <ipc/ipc.h>
 #include <ipc/adb.h>
 #include <async.h>
@@ -68 +67 @@
 
         /* NB: The callback connection is slotted for removal */
-        sysarg_t taskhash;
-        sysarg_t phonehash;
-        if (ipc_connect_to_me(dev_phone, 0, 0, 0, &taskhash, &phonehash) != 0) {
+        if (async_connect_to_me(dev_phone, 0, 0, 0, adb_dev_events) != 0) {
                 printf(NAME ": Failed to create callback from device\n");
                 return false;
         }
-
-        async_new_connection(taskhash, phonehash, 0, NULL, adb_dev_events);
-
+        
         return 0;
 }
@@ -100 +95 @@
                         retval = ENOENT;
                 }
-                ipc_answer_0(callid, retval);
+                async_answer_0(callid, retval);
         }
 }