Changeset 41bbab6 in mainline

Timestamp:

2018-03-26T15:26:44Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

92cf9a4

Parents:

81b1db8

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-26 15:21:43)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-26 15:26:44)

Message:

Check for path length overflow in rm.

File:

• uspace/app/bdsh/cmds/modules/rm/rm.c (modified) (1 diff)

uspace/app/bdsh/cmds/modules/rm/rm.c

@@ -174 +174 @@
         memset(buff, 0, sizeof(buff));
         while ((dp = readdir(dirp))) {
-                snprintf(buff, PATH_MAX - 1, "%s/%s", path, dp->d_name);
+                int len = snprintf(buff, PATH_MAX - 1, "%s/%s", path, dp->d_name);
+                if (len > PATH_MAX-1) {
+                        // TODO: Do not enforce arbitrary static limits.
+                        cli_error(CL_EFAIL, "Path too long for %s/%s", path, dp->d_name);
+                        continue;
+                }
                 scope = rm_scope(buff);
                 switch (scope) {