Changeset 4125b7d in mainline for uspace/drv/uhci-hcd/uhci.c

Timestamp:

2011-04-18T20:06:55Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

84a04dd, bbdf09e

Parents:

5ab4a48

Message:

usb_log_printf() checks for printf correctness

It is surprising how many printf warnings simple check could
produce .

Next time, it won't compile. Bad, huh?

File:

• uspace/drv/uhci-hcd/uhci.c (modified) (1 diff)

uspace/drv/uhci-hcd/uhci.c

@@ -168 +168 @@
             pci_get_my_registers(device, &io_reg_base, &io_reg_size, &irq);
         CHECK_RET_DEST_FUN_RETURN(ret,
-            "Failed(%d) to get I/O addresses:.\n", ret, device->handle);
-        usb_log_debug("I/O regs at 0x%X (size %zu), IRQ %d.\n",
-            io_reg_base, io_reg_size, irq);
+            "Failed to get I/O addresses for %" PRIun ": %s.\n",
+            device->handle, str_error(ret));
+        usb_log_debug("I/O regs at 0x%p (size %zu), IRQ %d.\n",
+            (void *) io_reg_base, io_reg_size, irq);
 
         ret = pci_disable_legacy(device);