Changeset 40feeac in mainline for uspace/srv/vfs/vfs_ops.c

Timestamp:

2017-12-03T22:14:40Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

8e3498b

Parents:

38d150e

Message:

Avoid race condition in vfs_clone().

The file descriptor could have been reallocated between the freeing
and the assigning, which would make it fail spuriously. Avoid
the error by moving deallocation inside the critical section.

File:

• uspace/srv/vfs/vfs_ops.c (modified) (1 diff)

uspace/srv/vfs/vfs_ops.c

@@ -102 +102 @@
 
         if (newfd != -1) {
-                /* Make sure newfd is closed. */
-                (void) vfs_fd_free(newfd);
                 /* Assign the old file to newfd. */
                 rc = vfs_fd_assign(oldfile, newfd);