Changeset 3e6bca8 in mainline for uspace/srv/net/dhcp/dhcp.c

Timestamp:

2021-08-08T17:30:29Z (3 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a7f7b9c3

Parents:

b4edc96

Message:

Represent Ethernet address as a number instead of an array

Carefully document the design since this breaks the principle of least
surprise. Also add unit tests.

File:

• uspace/srv/net/dhcp/dhcp.c (modified) (2 diffs)

uspace/srv/net/dhcp/dhcp.c

@@ -162 +162 @@
         hdr->flags = flag_broadcast;
 
-        memcpy(dlink->link_info.mac_addr.b, hdr->chaddr,
-            sizeof(dlink->link_info.mac_addr.b));
+        eth_addr_encode(&dlink->link_info.mac_addr, hdr->chaddr);
         hdr->opt_magic = host2uint32_t_be(dhcp_opt_magic);
 
@@ -187 +186 @@
         hdr->flags = flag_broadcast;
         hdr->ciaddr = host2uint32_t_be(offer->oaddr.addr);
-        memcpy(hdr->chaddr, dlink->link_info.mac_addr.b, 6);
+        eth_addr_encode(&dlink->link_info.mac_addr, hdr->chaddr);
         hdr->opt_magic = host2uint32_t_be(dhcp_opt_magic);