Changeset 3e6bca8 in mainline for uspace/lib/inet/src/addr.c

Timestamp:

2021-08-08T17:30:29Z (3 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a7f7b9c3

Parents:

b4edc96

Message:

Represent Ethernet address as a number instead of an array

Carefully document the design since this breaks the principle of least
surprise. Also add unit tests.

File:

• uspace/lib/inet/src/addr.c (modified) (2 diffs)

uspace/lib/inet/src/addr.c

@@ -55 +55 @@
 const addr32_t addr32_broadcast_all_hosts = 0xffffffff;
 
-static const eth_addr_t inet_eth_addr_solicited_node = {
-        0x33, 0x33, 0xff, 0, 0, 0
-};
+static eth_addr_t inet_eth_addr_solicited_node =
+    ETH_ADDR_INITIALIZER(0x33, 0x33, 0xff, 0, 0, 0);
 
 static const inet_addr_t inet_addr_any_addr = {
@@ -91 +90 @@
 void eth_addr_solicited_node(const addr128_t ip, eth_addr_t *mac)
 {
-        memcpy(&mac->b[0], &inet_eth_addr_solicited_node.b[0], 3);
-        memcpy(&mac->b[3], ip + 13, 3);
+        uint8_t b[6];
+        mac->a = inet_eth_addr_solicited_node.a;
+
+        eth_addr_encode(&inet_eth_addr_solicited_node, b);
+        memcpy(&b[3], ip + 13, 3);
+        eth_addr_decode(b, mac);
 }