Changeset 3e6bca8 in mainline for uspace/app/inet/inet.c

Timestamp:

2021-08-08T17:30:29Z (3 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a7f7b9c3

Parents:

b4edc96

Message:

Represent Ethernet address as a number instead of an array

Carefully document the design since this breaks the principle of least
surprise. Also add unit tests.

File:

• uspace/app/inet/inet.c (modified) (3 diffs)

uspace/app/inet/inet.c

@@ -37 +37 @@
 #include <errno.h>
 #include <inet/addr.h>
+#include <inet/eth_addr.h>
 #include <inet/inetcfg.h>
 #include <io/table.h>
@@ -340 +341 @@
         inet_link_info_t linfo;
         table_t *table = NULL;
+        eth_addr_str_t saddr;
 
         size_t count;
@@ -368 +370 @@
                 }
 
-                table_printf(table, "%02x:%02x:%02x:%02x:%02x:%02x\t"
-                    "%s\t" "%zu\n",
-                    linfo.mac_addr.b[0], linfo.mac_addr.b[1],
-                    linfo.mac_addr.b[2], linfo.mac_addr.b[3],
-                    linfo.mac_addr.b[4], linfo.mac_addr.b[5],
-                    linfo.name, linfo.def_mtu);
+                eth_addr_format(&linfo.mac_addr, &saddr);
+                table_printf(table, "%s\t %s\t %zu\n", saddr.str, linfo.name,
+                    linfo.def_mtu);
 
                 free(linfo.name);