Changeset 3ca4ae9 in mainline for uspace/lib/usbhid/src/hiddescriptor.c

Timestamp:

2017-12-20T15:51:07Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4547f11

Parents:

68a2fab2

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2017-12-20 15:46:56)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2017-12-20 15:51:07)

Message:

Fix error code mixing in usbhid.

File:

• uspace/lib/usbhid/src/hiddescriptor.c (modified) (11 diffs)

uspace/lib/usbhid/src/hiddescriptor.c

@@ -75 +75 @@
 #define USB_HID_RESET_OFFSET    3
 
+#define USB_HID_INVALID                 -98
 /** Unknown tag was founded in report descriptor data*/
 #define USB_HID_UNKNOWN_TAG             -99
@@ -103 +104 @@
                 
                 if(usb_hid_report_compare_usage_path(path, cmp_path,
-                                        USB_HID_PATH_COMPARE_STRICT) == EOK){
+                                        USB_HID_PATH_COMPARE_STRICT) == 0){
                         break;
                 }
@@ -553 +554 @@
 
                 if((ret=usb_hid_report_parse_main_tag(tag, data, item_size,
-                        report_item, usage_path)) == EOK) {
+                        report_item, usage_path)) == 0) {
 
                         return USB_HID_NEW_REPORT_ITEM;
@@ -584 +585 @@
  * @param Length of data buffer
  * @param Current state table
- * @return Error code
+ * @return 0 or USB_HID_ code
  */
 
@@ -599 +600 @@
         case USB_HID_REPORT_TAG_FEATURE:
                 report_item->item_flags = *data;                        
-                return EOK;                     
+                return 0;                       
                 break;
                         
@@ -639 +640 @@
         }
 
-        return EOK;
+        return 0;
 }
 
@@ -649 +650 @@
  * @param Length of data buffer
  * @param Current state table
- * @return Error code
+ * @return 0 or USB_HID_ code
  */
 int usb_hid_report_parse_global_tag(uint8_t tag, const uint8_t *data, 
@@ -725 +726 @@
         }
 
-        return EOK;
+        return 0;
 }
 
@@ -735 +736 @@
  * @param Length of data buffer
  * @param Current state table
- * @return Error code
+ * @return 0 or USB_HID_ code
  */
 int usb_hid_report_parse_local_tag(uint8_t tag, const uint8_t *data,
@@ -791 +792 @@
                             USB_HID_EXTENDED_USAGE_PAGE(
                             usb_hid_report_tag_data_uint32(data, item_size))) {
-                                return EINVAL;
+                                return USB_HID_INVALID;
                         }
                         
@@ -862 +863 @@
         }
         
-        return EOK;
+        return 0;
 }