Changeset 3a6e423 in mainline for uspace/lib/usb/src/hidpath.c

Timestamp:

2011-05-08T19:38:24Z (13 years ago)

Author:

Matej Klonfar <maklf@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7aaf403e

Parents:

7b6f116

Message:

Parsing of usages in case of array items repaired

File:

• uspace/lib/usb/src/hidpath.c (modified) (4 diffs)

uspace/lib/usb/src/hidpath.c

@@ -42 +42 @@
 
 
+#define USB_HID_SAME_USAGE(usage1, usage2)      ((usage1 == usage2) || (usage1 == 0) || (usage2 == 0))
+#define USB_HID_SAME_USAGE_PAGE(page1, page2)   ((page1 == page2) || (page1 == 0) || (page2 == 0))
+
 /**
  * Appends one item (couple of usage_path and usage) into the usage path
@@ -203 +206 @@
                         while(report_link != &report_path->head) {
                                 report_item = list_get_instance(report_link, usb_hid_report_usage_path_t, link);
-                                if(report_item->usage_page == path_item->usage_page){
+                                if(USB_HID_SAME_USAGE_PAGE(report_item->usage_page, path_item->usage_page)){
                                         if(only_page == 0){
-                                                if(report_item->usage == path_item->usage) {
+                                                if(USB_HID_SAME_USAGE(report_item->usage, path_item->usage)) {
                                                         return EOK;
                                                 }
@@ -242 +245 @@
                                                                       link);            
 
-                                        if((report_item->usage_page != path_item->usage_page) || 
+                                        if(!USB_HID_SAME_USAGE_PAGE(report_item->usage_page, path_item->usage_page) || 
                                            ((only_page == 0) && 
-                                            (report_item->usage != path_item->usage))) {
+                                            !USB_HID_SAME_USAGE(report_item->usage, path_item->usage))) {
                                                         
                                                    return 1;
@@ -282 +285 @@
                                                                       usb_hid_report_usage_path_t, 
                                                                       link);            
-
-                                        if((report_item->usage_page != path_item->usage_page) || 
+                                                  
+                                        if(!USB_HID_SAME_USAGE_PAGE(report_item->usage_page, path_item->usage_page) || 
                                            ((only_page == 0) && 
-                                            (report_item->usage != path_item->usage))) {
-                                                   return 1;
+                                            !USB_HID_SAME_USAGE(report_item->usage, path_item->usage))) {
+                                                        return 1;
                                         } else {
                                                 report_link = report_link->prev;