Changes in uspace/srv/devman/main.c [c6c389ed:38b3baf] in mainline

File:

• uspace/srv/devman/main.c (modified) (18 diffs)

uspace/srv/devman/main.c

@@ -66 +66 @@
 static driver_t *devman_driver_register(void)
 {
+        printf(NAME ": devman_driver_register \n");
+        
         ipc_call_t icall;
-        ipc_callid_t iid;
+        ipc_callid_t iid = async_get_call(&icall);
         driver_t *driver = NULL;
-
-        printf(NAME ": devman_driver_register \n");
-        
-        iid = async_get_call(&icall);
+        
         if (IPC_GET_METHOD(icall) != DEVMAN_DRIVER_REGISTER) {
                 ipc_answer_0(iid, EREFUSED);
@@ -86 +85 @@
                 return NULL;
         }
-
         printf(NAME ": the %s driver is trying to register by the service.\n",
             drv_name);
@@ -93 +91 @@
         driver = find_driver(&drivers_list, drv_name);
         
-        if (driver == NULL) {
+        if (NULL == driver) {
                 printf(NAME ": no driver named %s was found.\n", drv_name);
                 free(drv_name);
@@ -148 +146 @@
         }
         
-        if (match_id == NULL) {
+        if (NULL == match_id) {
                 printf(NAME ": ERROR: devman_receive_match_id - failed to "
                     "allocate match id.\n");
@@ -162 +160 @@
         rc = async_data_write_accept((void **) &match_id_str, true, 0, 0, 0, 0);
         match_id->id = match_id_str;
-        if (rc != EOK) {
+        if (EOK != rc) {
                 delete_match_id(match_id);
                 printf(NAME ": devman_receive_match_id - failed to receive "
@@ -183 +181 @@
  * @return              Zero on success, negative error code otherwise.
  */
-static int devman_receive_match_ids(ipcarg_t match_count,
-    match_id_list_t *match_ids)
+static int
+devman_receive_match_ids(ipcarg_t match_count, match_id_list_t *match_ids)
 {
         int ret = EOK;
@@ -207 +205 @@
         
         fibril_rwlock_write_lock(&tree->rwlock);
-        node_t *parent = find_dev_node_no_lock(&device_tree, parent_handle);
-        
-        if (parent == NULL) {
+        node_t *parent =  find_dev_node_no_lock(&device_tree, parent_handle);
+        
+        if (NULL == parent) {
                 fibril_rwlock_write_unlock(&tree->rwlock);
                 ipc_answer_0(callid, ENOENT);
                 return;
-        }
+        }       
         
         char *dev_name = NULL;
         int rc = async_data_write_accept((void **)&dev_name, true, 0, 0, 0, 0);
-        if (rc != EOK) {
+        if (EOK != rc) {
                 fibril_rwlock_write_unlock(&tree->rwlock);
                 ipc_answer_0(callid, rc);
@@ -229 +227 @@
                 ipc_answer_0(callid, ENOMEM);
                 return;
-        }
-
+        }       
         fibril_rwlock_write_unlock(&tree->rwlock);
         
@@ -248 +245 @@
         /* Create devmap path and name for the device. */
         char *devmap_pathname = NULL;
-
         asprintf(&devmap_pathname, "%s/%s%c%s", DEVMAP_CLASS_NAMESPACE,
             cli->dev_class->name, DEVMAP_SEPARATOR, cli->dev_name);
-        if (devmap_pathname == NULL)
+        if (NULL == devmap_pathname)
                 return;
         
@@ -283 +279 @@
         
         node_t *dev = find_dev_node(&device_tree, handle);
-        if (dev == NULL) {
+        if (NULL == dev) {
                 ipc_answer_0(callid, ENOENT);
                 return;
@@ -322 +318 @@
         
         driver_t *driver = devman_driver_register();
-        if (driver == NULL)
+        if (NULL == driver)
                 return;
         
@@ -377 +373 @@
         free(pathname);
 
-        if (dev == NULL) {
+        if (NULL == dev) {
                 ipc_answer_0(iid, ENOENT);
                 return;
@@ -408 +404 @@
                                 ipc_answer_0(callid, ENOENT);
                 }
-        }
-}
-
-static void devman_forward(ipc_callid_t iid, ipc_call_t *icall,
-    bool drv_to_parent)
+        }       
+}
+
+static void
+devman_forward(ipc_callid_t iid, ipc_call_t *icall, bool drv_to_parent)
 {
         device_handle_t handle = IPC_GET_ARG2(*icall);
         
         node_t *dev = find_dev_node(&device_tree, handle);
-        if (dev == NULL) {
+        if (NULL == dev) {
                 printf(NAME ": devman_forward error - no device with handle %x "
                     "was found.\n", handle);
@@ -427 +423 @@
         
         if (drv_to_parent) {
-                if (dev->parent != NULL)
+                if (NULL != dev->parent)
                         driver = dev->parent->drv;
-        } else if (dev->state == DEVICE_USABLE) {
+        } else if (DEVICE_USABLE == dev->state) {
                 driver = dev->drv;
-                assert(driver != NULL);
-        }
-        
-        if (driver == NULL) {
+                assert(NULL != driver);
+        }
+        
+        if (NULL == driver) {
                 printf(NAME ": devman_forward error - the device is not in "
                     "usable state.\n", handle);
@@ -454 +450 @@
                 return;
         }
-
         printf(NAME ": devman_forward: forward connection to device %s to "
             "driver %s.\n", dev->pathname, driver->name);
@@ -465 +460 @@
 {
         dev_handle_t devmap_handle = IPC_GET_METHOD(*icall);
-        node_t *dev;
-
-        dev = find_devmap_tree_device(&device_tree, devmap_handle);
-        if (dev == NULL)
+        
+        node_t *dev = find_devmap_tree_device(&device_tree, devmap_handle);
+        if (NULL == dev)
                 dev = find_devmap_class_device(&class_list, devmap_handle);
         
-        if (dev == NULL || dev->drv == NULL) {
+        if (NULL == dev || NULL == dev->drv) {
                 ipc_answer_0(iid, ENOENT);
                 return;
         }
         
-        if (dev->state != DEVICE_USABLE || dev->drv->phone <= 0) {
+        if (DEVICE_USABLE != dev->state || dev->drv->phone <= 0) {
                 ipc_answer_0(iid, EINVAL);
                 return;
@@ -499 +493 @@
          * passes device handle to the driver as an ipc method.)
          */
-        if (IPC_GET_METHOD(*icall) != IPC_M_CONNECT_ME_TO)
+        if (IPC_M_CONNECT_ME_TO != IPC_GET_METHOD(*icall))
                 devman_connection_devmapper(iid, icall);
 
@@ -537 +531 @@
         /* Initialize list of available drivers. */
         init_driver_list(&drivers_list);
-        if (lookup_available_drivers(&drivers_list,
-            DRIVER_DEFAULT_STORE) == 0) {
+        if (0 == lookup_available_drivers(&drivers_list,
+            DRIVER_DEFAULT_STORE)) {
                 printf(NAME " no drivers found.");
                 return false;
         }
-
         printf(NAME ": devman_init  - list of drivers has been initialized.\n");