Changeset 35c37fc in mainline for uspace/drv/bus/usb/ehci/hw_struct/transfer_descriptor.h

Timestamp:

2018-01-05T20:15:08Z (6 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9e5b162

Parents:

b60944b

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-05 16:11:04)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-05 20:15:08)

Message:

ehci: refactor to dma_buffers

One big hidden thing was refactored - now TDs are allocated in one
buffer together with setup and data buffers themselves. This reduces the
number of allocated pages per transfer to minimum.

File:

• uspace/drv/bus/usb/ehci/hw_struct/transfer_descriptor.h (modified) (3 diffs)

uspace/drv/bus/usb/ehci/hw_struct/transfer_descriptor.h

@@ -37 +37 @@
 #include <stddef.h>
 #include <stdint.h>
+#include <macros.h>
 #include "link_pointer.h"
 #include "mem_access.h"
@@ -75 +76 @@
         /* 64 bit struct only */
         volatile uint32_t extended_bp[5];
-} td_t;
+
+        /* TDs must be 32-byte aligned */
+        PADD32 [3];
+
+} __attribute__((packed)) td_t;
+
+static_assert(sizeof(td_t) % 32 == 0);
 
 static inline bool td_active(const td_t *td)
@@ -92 +99 @@
 int td_error(const td_t *td);
 
-void td_init(td_t *td, const td_t *next, usb_direction_t dir, const void * buf,
+void td_init(td_t *td, uintptr_t next_phys, uintptr_t buf, usb_direction_t dir,
     size_t buf_size, int toggle, bool ioc);