Changeset 35bb2e7 in mainline for kernel/generic/src/ipc/sysipc.c

Timestamp:

2009-11-19T21:02:52Z (14 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4ca28512

Parents:

4e739652

Message:

Allocate the call structure for synchronous calls dynamically.

File:

• kernel/generic/src/ipc/sysipc.c (modified) (3 diffs)

kernel/generic/src/ipc/sysipc.c

@@ -531 +531 @@
     unative_t arg1, unative_t arg2, unative_t arg3, ipc_data_t *data)
 {
-        call_t call;
+        call_t *call;
         phone_t *phone;
         int res;
@@ -538 +538 @@
         GET_CHECK_PHONE(phone, phoneid, return ENOENT);
 
-        ipc_call_static_init(&call);
-        IPC_SET_METHOD(call.data, method);
-        IPC_SET_ARG1(call.data, arg1);
-        IPC_SET_ARG2(call.data, arg2);
-        IPC_SET_ARG3(call.data, arg3);
+        call = ipc_call_alloc(0);
+        IPC_SET_METHOD(call->data, method);
+        IPC_SET_ARG1(call->data, arg1);
+        IPC_SET_ARG2(call->data, arg2);
+        IPC_SET_ARG3(call->data, arg3);
         /*
          * To achieve deterministic behavior, zero out arguments that are beyond
          * the limits of the fast version.
          */
-        IPC_SET_ARG4(call.data, 0);
-        IPC_SET_ARG5(call.data, 0);
-
-        if (!(res = request_preprocess(&call, phone))) {
+        IPC_SET_ARG4(call->data, 0);
+        IPC_SET_ARG5(call->data, 0);
+
+        if (!(res = request_preprocess(call, phone))) {
 #ifdef CONFIG_UDEBUG
                 udebug_stoppable_begin();
 #endif
-                rc = ipc_call_sync(phone, &call);
+                rc = ipc_call_sync(phone, call);
 #ifdef CONFIG_UDEBUG
                 udebug_stoppable_end();
 #endif
-                if (rc != EOK)
+                if (rc != EOK) {
+                        /* The call will be freed by someone else. */
                         return rc;
-                process_answer(&call);
+                }
+                process_answer(call);
 
         } else {
-                IPC_SET_RETVAL(call.data, res);
-        }
-        rc = STRUCT_TO_USPACE(&data->args, &call.data.args);
+                IPC_SET_RETVAL(call->data, res);
+        }
+        rc = STRUCT_TO_USPACE(&data->args, &call->data.args);
+        ipc_call_free(call);
         if (rc != 0)
                 return rc;
@@ -584 +587 @@
     ipc_data_t *reply)
 {
-        call_t call;
+        call_t *call;
         phone_t *phone;
         int res;
         int rc;
 
-        ipc_call_static_init(&call);
-        rc = copy_from_uspace(&call.data.args, &question->args,
-            sizeof(call.data.args));
-        if (rc != 0)
+        GET_CHECK_PHONE(phone, phoneid, return ENOENT);
+
+        call = ipc_call_alloc(0);
+        rc = copy_from_uspace(&call->data.args, &question->args,
+            sizeof(call->data.args));
+        if (rc != 0) {
+                ipc_call_free(call);
                 return (unative_t) rc;
-
-        GET_CHECK_PHONE(phone, phoneid, return ENOENT);
-
-        if (!(res = request_preprocess(&call, phone))) {
+        }
+
+
+        if (!(res = request_preprocess(call, phone))) {
 #ifdef CONFIG_UDEBUG
                 udebug_stoppable_begin();
 #endif
-                rc = ipc_call_sync(phone, &call);
+                rc = ipc_call_sync(phone, call);
 #ifdef CONFIG_UDEBUG
                 udebug_stoppable_end();
 #endif
-                if (rc != EOK)
+                if (rc != EOK) {
+                        /* The call will be freed by someone else. */
                         return rc;
-                process_answer(&call);
+                }
+                process_answer(call);
         } else 
-                IPC_SET_RETVAL(call.data, res);
-
-        rc = STRUCT_TO_USPACE(&reply->args, &call.data.args);
+                IPC_SET_RETVAL(call->data, res);
+
+        rc = STRUCT_TO_USPACE(&reply->args, &call->data.args);
+        ipc_call_free(call);
         if (rc != 0)
                 return rc;