Changeset 357b5f5 in mainline for uspace/drv/ns8250/ns8250.c

Timestamp:

2011-01-23T20:09:13Z (13 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fdb9982c

Parents:

cead2aa (diff), 7e36c8d (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge mainline changes.

File:

• uspace/drv/ns8250/ns8250.c (modified) (10 diffs)

uspace/drv/ns8250/ns8250.c

@@ -53 +53 @@
 
 #include <driver.h>
-#include <char.h>
-#include <resource.h>
+#include <ops/char_dev.h>
 
 #include <devman.h>
@@ -227 +226 @@
 
 /** The character interface's callbacks. */
-static char_iface_t ns8250_char_iface = {
+static char_dev_ops_t ns8250_char_dev_ops = {
         .read = &ns8250_read,
         .write = &ns8250_write
@@ -274 +273 @@
         
         /* Gain control over port's registers. */
-        if (pio_enable((void *) data->io_addr, REG_COUNT,
+        if (pio_enable((void *)(uintptr_t) data->io_addr, REG_COUNT,
             (void **) &data->port)) {
                 printf(NAME ": error - cannot gain the port %#" PRIx32 " for device "
@@ -342 +341 @@
                 printf(NAME ": failed to connect to the parent driver of the "
                     "device %s.\n", dev->name);
-                ret = EPARTY;   /* FIXME: use another EC */
+                ret = dev->parent_phone;
                 goto failed;
         }
         
         /* Get hw resources. */
-        if (!get_hw_resources(dev->parent_phone, &hw_resources)) {
+        ret = hw_res_get_resource_list(dev->parent_phone, &hw_resources);
+        if (ret != EOK) {
                 printf(NAME ": failed to get hw resources for the device "
                     "%s.\n", dev->name);
-                ret = EPARTY;   /* FIXME: use another EC */
                 goto failed;
         }
@@ -374 +373 @@
                                 printf(NAME ": i/o range assigned to the device "
                                     "%s is too small.\n", dev->name);
-                                ret = EPARTY;   /* FIXME: use another EC */
+                                ret = ELIMIT;
                                 goto failed;
                         }
@@ -390 +389 @@
                 printf(NAME ": missing hw resource(s) for the device %s.\n",
                     dev->name);
-                ret = EPARTY;   /* FIXME: use another EC */
+                ret = ENOENT;
                 goto failed;
         }
         
-        clean_hw_resource_list(&hw_resources);
+        hw_res_clean_resource_list(&hw_resources);
         return ret;
         
 failed:
         ns8250_dev_cleanup(dev);
-        clean_hw_resource_list(&hw_resources);
+        hw_res_clean_resource_list(&hw_resources);
         return ret;
 }
@@ -432 +431 @@
 {
         ns8250_dev_data_t *data = (ns8250_dev_data_t *) dev->driver_data;
-        int res;
-        
-        /* Enable interrupt globally. */
-        res = interrupt_enable(data->irq);
-        if (res != EOK)
-                return res;
         
         /* Enable interrupt on the serial port. */
@@ -727 +720 @@
 {
         printf(NAME ": ns8250_add_device %s (handle = %d)\n",
-            dev->name, dev->handle);
+            dev->name, (int) dev->handle);
         
         int res = ns8250_dev_initialize(dev);
@@ -887 +880 @@
     ipc_call_t *call)
 {
-        ipcarg_t method = IPC_GET_METHOD(*call);
+        sysarg_t method = IPC_GET_IMETHOD(*call);
         int ret;
         unsigned int baud_rate, parity, word_length, stop_bits;
@@ -924 +917 @@
         ns8250_dev_ops.close = &ns8250_close;
         
-        ns8250_dev_ops.interfaces[CHAR_DEV_IFACE] = &ns8250_char_iface;
+        ns8250_dev_ops.interfaces[CHAR_DEV_IFACE] = &ns8250_char_dev_ops;
         ns8250_dev_ops.default_handler = &ns8250_default_handler;
 }