Changeset 32b2a6f2 in mainline

Timestamp:

2018-01-21T16:47:05Z (6 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

cd3fa47

Parents:

b310cff4

Message:

usbhub: link state change cannot be cleared

File:

• uspace/drv/bus/usb/usbhub/port.c (modified) (3 diffs)

uspace/drv/bus/usb/usbhub/port.c

@@ -218 +218 @@
 }
 
-static void port_changed_link_state(usb_hub_port_t *port, usb_port_status_t status)
-{
-        port_log(debug2, port, "Port link state changed.");
-}
-
-
 typedef void (*change_handler_t)(usb_hub_port_t *, usb_port_status_t);
 
@@ -232 +226 @@
         [USB_HUB_FEATURE_C_PORT_OVER_CURRENT] = &port_changed_overcurrent,
         [USB_HUB_FEATURE_C_PORT_RESET] = &port_changed_reset,
-        [USB_HUB_FEATURE_C_PORT_LINK_STATE] = &port_changed_link_state,
         [sizeof(usb_port_status_t) * 8] = NULL,
 };
@@ -255 +248 @@
         }
 
+        if (port->hub->speed == USB_SPEED_SUPER)
+                /* Link state change is not a change we shall clear, nor we care about it */
+                status &= ~(1 << USB_HUB_FEATURE_C_PORT_LINK_STATE);
+
         for (uint32_t feature = 16; feature < sizeof(usb_port_status_t) * 8; ++feature) {
                 uint32_t mask = 1 << feature;