Changeset 2fbd49c in mainline for uspace/srv/audio/hound/audio_sink.h

Timestamp:

2022-09-22T09:01:32Z (19 months ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

2139676

Parents:

a76e76b

git-author:

Jiri Svoboda <jiri@…> (2022-09-21 18:01:20)

git-committer:

Jiri Svoboda <jiri@…> (2022-09-22 09:01:32)

Message:

Audio synk needs locking

Without locking the list of sink connections, we are exposed
to a race between removing a connection at the end of playback
(typically while destroying a hound context) and audio device
event PCM_EVENT_FRAMES_PLAYED which causes audio mixing to occur
via audio_sink_mix_inputs(), causing hound to crash often at
the end of playback.

File:

• uspace/srv/audio/hound/audio_sink.h (modified) (2 diffs)

uspace/srv/audio/hound/audio_sink.h

@@ -41 +41 @@
 #include <stdbool.h>
 #include <fibril.h>
+#include <fibril_synch.h>
 #include <pcm/format.h>
 
@@ -51 +52 @@
         /** Link in hound's sink list */
         link_t link;
+        /** Protect sink including list of connections */
+        fibril_mutex_t lock;
         /** List of all related connections */
         list_t connections;