Fork us on GitHub Follow us on Facebook Follow us on Twitter

Changeset 2e7692f in mainline


Ignore:
Timestamp:
2017-07-23T19:31:48Z (3 years ago)
Author:
Jaroslav Jindrak <dzejrou@…>
Branches:
master
Children:
eff60ca
Parents:
c46c356
Message:

Removed redundant setting of the trb's pcs flag - it is set in xhci_trb_ring_enqueue.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/drv/bus/usb/xhci/commands.c

    rc46c356 r2e7692f  
    231231        trb.control = host2xhci(32, XHCI_TRB_TYPE_ENABLE_SLOT_CMD << 10);
    232232        trb.control |= host2xhci(32, XHCI_REG_RD(hc->xecp, XHCI_EC_SP_SLOT_TYPE) << 16);
    233         trb.control |= host2xhci(32, hc->command_ring.pcs);
    234233
    235234        cmd = add_cmd(hc, cmd);
     
    247246
    248247        trb.control = host2xhci(32, XHCI_TRB_TYPE_DISABLE_SLOT_CMD << 10);
    249         trb.control |= host2xhci(32, hc->command_ring.pcs);
    250248        trb.control |= host2xhci(32, cmd->slot_id << 24);
    251249
     
    281279         */
    282280        trb.control = host2xhci(32, XHCI_TRB_TYPE_ADDRESS_DEVICE_CMD << 10);
    283         trb.control |= host2xhci(32, hc->command_ring.pcs);
    284281        trb.control |= host2xhci(32, cmd->slot_id << 24);
    285282
     
    302299
    303300        trb.control = host2xhci(32, XHCI_TRB_TYPE_CONFIGURE_ENDPOINT_CMD << 10);
    304         trb.control |= host2xhci(32, hc->command_ring.pcs);
    305301        trb.control |= host2xhci(32, cmd->slot_id << 24);
    306302
     
    329325
    330326        trb.control = host2xhci(32, XHCI_TRB_TYPE_EVALUATE_CONTEXT_CMD << 10);
    331         trb.control |= host2xhci(32, hc->command_ring.pcs);
    332327        trb.control |= host2xhci(32, cmd->slot_id << 24);
    333328
     
    350345
    351346        trb.control = host2xhci(32, XHCI_TRB_TYPE_RESET_ENDPOINT_CMD << 10);
    352         trb.control |= host2xhci(32, hc->command_ring.pcs);
    353347        trb.control |= host2xhci(32, (tcs & 0x1) << 9);
    354348        trb.control |= host2xhci(32, (ep_id & 0x5) << 16);
     
    367361
    368362        trb.control = host2xhci(32, XHCI_TRB_TYPE_STOP_ENDPOINT_CMD << 10);
    369         trb.control |= host2xhci(32, hc->command_ring.pcs);
    370363        trb.control |= host2xhci(32, (ep_id & 0x5) << 16);
    371364        trb.control |= host2xhci(32, (susp & 0x1) << 23);
     
    386379
    387380        trb.control = host2xhci(32, XHCI_TRB_TYPE_RESET_DEVICE_CMD << 10);
    388         trb.control |= host2xhci(32, hc->command_ring.pcs);
    389381        trb.control |= host2xhci(32, cmd->slot_id << 24);
    390382
Note: See TracChangeset for help on using the changeset viewer.