Changes in kernel/generic/src/printf/printf_core.c [6ab8697:2afb650] in mainline

File:

• kernel/generic/src/printf/printf_core.c (modified) (10 diffs)

kernel/generic/src/printf/printf_core.c

@@ -41 +41 @@
 #include <stdarg.h>
 #include <macros.h>
-#include <string.h>
+#include <str.h>
 #include <arch.h>
 
 /** show prefixes 0x or 0 */
 #define __PRINTF_FLAG_PREFIX       0x00000001
+
 /** signed / unsigned number */
 #define __PRINTF_FLAG_SIGNED       0x00000002
+
 /** print leading zeroes */
 #define __PRINTF_FLAG_ZEROPADDED   0x00000004
+
 /** align to left */
 #define __PRINTF_FLAG_LEFTALIGNED  0x00000010
+
 /** always show + sign */
 #define __PRINTF_FLAG_SHOWPLUS     0x00000020
+
 /** print space instead of plus */
 #define __PRINTF_FLAG_SPACESIGN    0x00000040
+
 /** show big characters */
 #define __PRINTF_FLAG_BIGCHARS     0x00000080
+
 /** number has - sign */
 #define __PRINTF_FLAG_NEGATIVE     0x00000100
@@ -79 +86 @@
 } qualifier_t;
 
-static char nullstr[] = "(NULL)";
-static char digits_small[] = "0123456789abcdef";
-static char digits_big[] = "0123456789ABCDEF";
-static char invalch = U_SPECIAL;
+static const char *nullstr = "(NULL)";
+static const char *digits_small = "0123456789abcdef";
+static const char *digits_big = "0123456789ABCDEF";
+static const char invalch = U_SPECIAL;
 
 /** Print one or more characters without adding newline.
@@ -254 +261 @@
         if (str == NULL)
                 return printf_putstr(nullstr, ps);
-
+        
         /* Print leading spaces. */
         size_t strw = str_length(str);
         if (precision == 0)
                 precision = strw;
-
+        
         /* Left padding */
         size_t counter = 0;
@@ -269 +276 @@
                 }
         }
-
+        
         /* Part of @a str fitting into the alloted space. */
         int retval;
@@ -351 +358 @@
     uint32_t flags, printf_spec_t *ps)
 {
-        char *digits;
+        const char *digits;
         if (flags & __PRINTF_FLAG_BIGCHARS)
                 digits = digits_big;
@@ -384 +391 @@
          */
         if (flags & __PRINTF_FLAG_PREFIX) {
-                switch(base) {
+                switch (base) {
                 case 2:
                         /* Binary formating is not standard, but usefull */
@@ -448 +455 @@
         /* Print prefix */
         if (flags & __PRINTF_FLAG_PREFIX) {
-                switch(base) {
+                switch (base) {
                 case 2:
                         /* Binary formating is not standard, but usefull */
@@ -563 +570 @@
  *
  *  - P, p Print value of a pointer. Void * value is expected and it is
- *         printed in hexadecimal notation with prefix (as with \%#X / \%#x
- *         for 32-bit or \%#X / \%#x for 64-bit long pointers).
+ *         printed in hexadecimal notation with prefix (as with
+ *         \%#0.8X / \%#0.8x for 32-bit or \%#0.16lX / \%#0.16lx for 64-bit
+ *         long pointers).
  *
  *  - b Print value as unsigned binary number. Prefix is not printed by
@@ -777 +785 @@
                         case 'p':
                                 flags |= __PRINTF_FLAG_PREFIX;
+                                flags |= __PRINTF_FLAG_ZEROPADDED;
                                 base = 16;
                                 qualifier = PrintfQualifierPointer;
@@ -839 +848 @@
                         case PrintfQualifierPointer:
                                 size = sizeof(void *);
-                                number = (uint64_t) (unsigned long) va_arg(ap, void *);
+                                precision = size << 1;
+                                number = (uint64_t) (uintptr_t) va_arg(ap, void *);
                                 break;
                         default: