Changeset 2a103b5 in mainline for kernel/arch/ia32/src/smp/apic.c

Timestamp:

2019-06-09T11:31:38Z (5 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

c48de91

Parents:

b401b33

Message:

Introduce PIC operations indirection mechanism

Some architectures switch from one interrupt controller implementation
to another during runtime. By providing a cleaner indirection mechanism,
it is possible e.g. for the ia32 IRQ 7 handler to distinguish i8259
spurious interrupts from actual IRQ 7 device interrupts, even when the
i8259 interrupt controller is no longer active.

File:

• kernel/arch/ia32/src/smp/apic.c (modified) (5 diffs)

kernel/arch/ia32/src/smp/apic.c

@@ -47 +47 @@
 #include <arch.h>
 #include <ddi/irq.h>
+#include <genarch/pic/pic_ops.h>
 
 #ifdef CONFIG_SMP
@@ -63 +64 @@
  */
 
+static const char *apic_get_name(void);
+static bool l_apic_is_spurious(unsigned int);
+static void l_apic_handle_spurious(unsigned int);
+
+pic_ops_t apic_pic_ops = {
+        .get_name = apic_get_name,
+        .enable_irqs = io_apic_enable_irqs,
+        .disable_irqs = io_apic_disable_irqs,
+        .eoi = l_apic_eoi,
+        .is_spurious = l_apic_is_spurious,
+        .handle_spurious = l_apic_handle_spurious,
+};
+
 /*
  * These variables either stay configured as initilalized, or are changed by
@@ -125 +139 @@
 #endif /* LAPIC_VERBOSE */
 
+const char *apic_get_name(void)
+{
+        return "apic";
+}
+
+bool l_apic_is_spurious(unsigned int n)
+{
+        return n == VECTOR_APIC_SPUR;
+}
+
+void l_apic_handle_spurious(unsigned int n)
+{
+}
+
 /** APIC spurious interrupt handler.
  *
@@ -134 +162 @@
     istate_t *istate __attribute__((unused)))
 {
-#ifdef CONFIG_DEBUG
-        log(LF_ARCH, LVL_DEBUG, "cpu%u: APIC spurious interrupt", CPU->id);
-#endif
 }
 
@@ -175 +200 @@
             (iroutine_t) apic_spurious);
 
-        enable_irqs_function = io_apic_enable_irqs;
-        disable_irqs_function = io_apic_disable_irqs;
-        eoi_function = l_apic_eoi;
-        irqs_info = "apic";
+        pic_ops = &apic_pic_ops;
 
         /*