Changeset 25a179e in mainline for uspace/lib/drv/generic/remote_nic.c

Timestamp:

2017-12-20T19:51:45Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f96b6c8

Parents:

d4a829e

Message:

IPC return values are always errno constants. Adjust types to reflect that.

In principle, IPC server is not allowed to return non-errno values via
the "main" return value, because kernel interprets it (e.g. EHANGUP).
It's still possible to return arbitrary additional return values alongside EOK,
which are not interpreted in normal communication.

File:

• uspace/lib/drv/generic/remote_nic.c (modified) (12 diffs)

uspace/lib/drv/generic/remote_nic.c

@@ -105 +105 @@
         aid_t req = async_send_1(exch, DEV_IFACE_ID(NIC_DEV_IFACE),
             NIC_SEND_MESSAGE, &answer);
-        sysarg_t retval = async_data_write_start(exch, data, size);
+        int retval = async_data_write_start(exch, data, size);
         
         async_exchange_end(exch);
@@ -131 +131 @@
         ipc_call_t answer;
         int rc;
-        sysarg_t retval;
+        int retval;
         
         async_exch_t *exch = async_exchange_begin(dev_sess);
@@ -147 +147 @@
         
         async_wait_for(req, &retval);
-        return (int) retval;
+        return retval;
 }
 
@@ -210 +210 @@
         async_exchange_end(exch);
         
-        sysarg_t res;
+        int res;
         async_wait_for(aid, &res);
         
@@ -237 +237 @@
         async_exchange_end(exch);
         
-        sysarg_t res;
+        int res;
         async_wait_for(aid, &res);
         
@@ -295 +295 @@
         async_exchange_end(exch);
 
-        sysarg_t res;
+        int res;
         async_wait_for(aid, &res);
         
@@ -629 +629 @@
         async_exchange_end(exch);
         
-        sysarg_t res;
+        int res;
         async_wait_for(message_id, &res);
         
@@ -717 +717 @@
         async_exchange_end(exch);
         
-        sysarg_t res;
+        int res;
         async_wait_for(message_id, &res);
         
@@ -878 +878 @@
         async_exchange_end(exch);
         
-        sysarg_t res;
+        int res;
         async_wait_for(message_id, &res);
         
@@ -938 +938 @@
         async_exchange_end(exch);
         
-        sysarg_t res;
+        int res;
         async_wait_for(message_id, &res);
         
@@ -997 +997 @@
             NIC_WOL_VIRTUE_ADD, (sysarg_t) type, send_data, &result);
         
-        sysarg_t res;
+        int res;
         if (send_data) {
                 int rc = async_data_write_start(exch, data, length);
@@ -1311 +1311 @@
         async_exchange_end(exch);
         
-        sysarg_t res;
+        int res;
         async_wait_for(message_id, &res);