Changeset 2405bb5 in mainline for kernel/generic/src/ipc/sysipc.c

Timestamp:

2012-08-15T19:28:43Z (12 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7975433

Parents:

691d8d8

Message:

Forget active calls when a task exits.

• Synchronization between answer and forget.
• Forgotten calls are not yet properly cleaned-up.
• Hold the sender task when processing its active calls.

File:

• kernel/generic/src/ipc/sysipc.c (modified) (3 diffs)

kernel/generic/src/ipc/sysipc.c

@@ -420 +420 @@
         int rc = EOK;
 
+        spinlock_lock(&answer->forget_lock);
+        if (answer->forget) {
+                /*
+                 * This is a forgotten call and answer->sender is not valid.
+                 */
+                spinlock_unlock(&answer->forget_lock);
+                /* TODO: free the call and its resources */
+                return rc;
+        } else {
+                /*
+                 * Hold the sender task so that it cannot suddenly disappear
+                 * while we are working with it.
+                 */
+                task_hold(answer->sender);
+        }
+        spinlock_unlock(&answer->forget_lock);
+
         if ((native_t) IPC_GET_RETVAL(answer->data) == EHANGUP) {
                 /* In case of forward, hangup the forwared phone,
@@ -434 +451 @@
         }
         
-        if (!olddata)
+        if (!olddata) {
+                task_release(answer->sender);
                 return rc;
+        }
         
         switch (IPC_GET_IMETHOD(*olddata)) {
@@ -469 +488 @@
         }
         
+        task_release(answer->sender);
+
         return rc;
 }