Changeset 1f43c8f in mainline for uspace/lib/usb/src/hcdhubd.c

Timestamp:

2010-11-28T22:14:41Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

78f01ff9, 7972b51

Parents:

ba7f671

Message:

Bugfixes and workarounds

Fixed problem when VHC died due to uninitialized list.

Another workaround for devman. Probably another deadlock. Oh, well.

File:

• uspace/lib/usb/src/hcdhubd.c (modified) (5 diffs)

uspace/lib/usb/src/hcdhubd.c

@@ -113 +113 @@
         }
 
-        rc = usb_hc_add_child_device(dev->generic, USB_HUB_DEVICE_NAME, id);
+        rc = usb_hc_add_child_device(dev->generic, USB_HUB_DEVICE_NAME, id, true);
         if (rc != EOK) {
                 free(id);
@@ -153 +153 @@
         add_match_id(&child->match_ids, match_id);
 
+        printf("%s: adding child device `%s' with match \"%s\"\n",
+            hc_driver->name, child->name, match_id->id);
         rc = child_device_register(child, child_info->parent);
-        printf("%s: adding child device with match \"%s\" (%s)\n",
-            hc_driver->name, match_id->id, str_error(rc));
+        printf("%s: child device `%s' registration: %s\n",
+            hc_driver->name, child->name, str_error(rc));
+
         if (rc != EOK) {
                 goto failure;
@@ -175 +178 @@
 leave:
         free(arg);
-        return rc;
+        return EOK;
 }
 
@@ -182 +185 @@
  * driven by the same task, the child adding is done in separate fibril.
  * Not optimal, but it works.
+ * Update: not under all circumstances the new fibril is successful either.
+ * Thus the last parameter to let the caller choose.
  *
  * @param parent Parent device.
  * @param name Device name.
  * @param match_id Match id.
+ * @param create_fibril Whether to run the addition in new fibril.
  * @return Error code.
  */
 int usb_hc_add_child_device(device_t *parent, const char *name,
-    const char *match_id)
-{
+    const char *match_id, bool create_fibril)
+{
+        printf("%s: about to add child device `%s' (%s)\n", hc_driver->name,
+            name, match_id);
+
         struct child_device_info *child_info
             = malloc(sizeof(struct child_device_info));
@@ -198 +207 @@
         child_info->match_id = match_id;
 
-        fid_t fibril = fibril_create(fibril_add_child_device, child_info);
-        if (!fibril) {
-                return ENOMEM;
-        }
-        fibril_add_ready(fibril);
+        if (create_fibril) {
+                fid_t fibril = fibril_create(fibril_add_child_device, child_info);
+                if (!fibril) {
+                        return ENOMEM;
+                }
+                fibril_add_ready(fibril);
+        } else {
+                fibril_add_child_device(child_info);
+        }
 
         return EOK;