Changeset 1ba37fa in mainline for kernel/generic/src/console/cmd.c

Timestamp:

2010-04-06T11:53:32Z (14 years ago)

Author:

Stanislav Kozina <stanislav.kozina@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

516adce

Parents:

f0dcdc5

Message:

Removed useless cycles sum, using ucycles + kcycles instead.

File:

• kernel/generic/src/console/cmd.c (modified) (7 diffs)

kernel/generic/src/console/cmd.c

@@ -1027 +1027 @@
         ipl_t ipl = interrupts_disable();
         spinlock_lock(&TASK->lock);
-        uint64_t ucycles, kcycles;
-        uint64_t t0 = task_get_accounting(TASK, &ucycles, &kcycles);
+        uint64_t ucycles0, kcycles0;
+        task_get_accounting(TASK, &ucycles0, &kcycles0);
         spinlock_unlock(&TASK->lock);
         interrupts_restore(ipl);
@@ -1037 +1037 @@
         
         /* Update and read thread accounting */
+        uint64_t ucycles1, kcycles1; 
         ipl = interrupts_disable();
         spinlock_lock(&TASK->lock);
-        uint64_t dt = task_get_accounting(TASK, &ucycles, &kcycles) - t0;
+        task_get_accounting(TASK, &ucycles1, &kcycles1);
         spinlock_unlock(&TASK->lock);
         interrupts_restore(ipl);
         
-        uint64_t cycles;
-        char suffix;
-        order(dt, &cycles, &suffix);
-                
-        printf("Time: %" PRIu64 "%c cycles\n", cycles, suffix);
+        uint64_t ucycles, kcycles;
+        char usuffix, ksuffix;
+        order(ucycles1 - ucycles0, &ucycles, &usuffix);
+        order(kcycles1 - kcycles0, &kcycles, &ksuffix);
+                
+        printf("Time: %" PRIu64 "%c user cycles, %" PRIu64 "%c kernel cycles\n",
+                        ucycles, usuffix, kcycles, ksuffix);
         
         if (ret == NULL) {
@@ -1062 +1065 @@
         uint32_t i;
         bool ret = true;
-        uint64_t cycles;
-        char suffix;
+        uint64_t ucycles, kcycles;
+        char usuffix, ksuffix;
         
         if (cnt < 1)
@@ -1081 +1084 @@
                 ipl_t ipl = interrupts_disable();
                 spinlock_lock(&TASK->lock);
-                uint64_t ucycles, kcycles;
-                uint64_t t0 = task_get_accounting(TASK, &ucycles, &kcycles);
+                uint64_t ucycles0, kcycles0;
+                task_get_accounting(TASK, &ucycles0, &kcycles0);
                 spinlock_unlock(&TASK->lock);
                 interrupts_restore(ipl);
@@ -1093 +1096 @@
                 ipl = interrupts_disable();
                 spinlock_lock(&TASK->lock);
-                uint64_t dt = task_get_accounting(TASK, &ucycles, &kcycles) - t0;
+                uint64_t ucycles1, kcycles1;
+                task_get_accounting(TASK, &ucycles1, &kcycles1);
                 spinlock_unlock(&TASK->lock);
                 interrupts_restore(ipl);
-                
+
                 if (ret != NULL) {
                         printf("%s\n", ret);
@@ -1103 +1107 @@
                 }
                 
-                data[i] = dt;
-                order(dt, &cycles, &suffix);
-                printf("OK (%" PRIu64 "%c cycles)\n", cycles, suffix);
+                data[i] = ucycles1 - ucycles0 + kcycles1 - kcycles0;
+                order(ucycles1 - ucycles0, &ucycles, &usuffix);
+                order(kcycles1 - kcycles0, &kcycles, &ksuffix);
+                printf("OK (%" PRIu64 "%c user cycles, %" PRIu64 "%c kernel cycles)\n",
+                                ucycles, usuffix, kcycles, ksuffix);
         }
         
@@ -1117 +1123 @@
                 }
                 
-                order(sum / (uint64_t) cnt, &cycles, &suffix);
-                printf("Average\t\t%" PRIu64 "%c\n", cycles, suffix);
+                order(sum / (uint64_t) cnt, &ucycles, &usuffix);
+                printf("Average\t\t%" PRIu64 "%c\n", ucycles, usuffix);
         }