Changeset 1ab8539 in mainline for uspace/lib/usbdev/src/hub.c

Timestamp:

2014-11-14T19:16:23Z (9 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5042706

Parents:

9696b01

Message:

remove system.uptime sysinfo entry since it is redundant
cleanup the time handling routines

• still more cleanup is needed here, the code is a wild combination of quasi-POSIX API (with all the brain-dead types, etc.) and HelenOS API

File:

• uspace/lib/usbdev/src/hub.c (modified) (2 diffs)

uspace/lib/usbdev/src/hub.c

@@ -162 +162 @@
         if (hc_conn == NULL)
                 return EINVAL;
-
-        int rc;
+        
         struct timeval start_time;
-
-        rc = gettimeofday(&start_time, NULL);
-        if (rc != EOK) {
+        gettimeofday(&start_time, NULL);
+        
+        /* We are gona do a lot of communication better open it in advance. */
+        int rc = usb_hc_connection_open(hc_conn);
+        if (rc != EOK)
                 return rc;
-        }
-
-        /* We are gona do a lot of communication better open it in advance. */
-        rc = usb_hc_connection_open(hc_conn);
-        if (rc != EOK) {
-                return rc;
-        }
-
+        
         /* Request a new address. */
         usb_address_t dev_addr =
@@ -226 +220 @@
                 goto leave_release_default_address;
         }
-
+        
         struct timeval end_time;
-        rc = gettimeofday(&end_time, NULL);
-        if (rc != EOK) {
-                goto leave_release_default_address;
-        }
-
+        gettimeofday(&end_time, NULL);
+        
         /* According to the USB spec part 9.1.2 host allows 100ms time for
          * the insertion process to complete. According to 7.1.7.1 this is the