Changeset 19ea61d in mainline for uspace/lib/c/generic/io/chardev_srv.c

Timestamp:

2017-11-20T20:01:24Z (6 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

677cad5

Parents:

c657bd7

Message:

Chardev should allow large data transfers.

File:

• uspace/lib/c/generic/io/chardev_srv.c (modified) (3 diffs)

uspace/lib/c/generic/io/chardev_srv.c

@@ -46 +46 @@
     ipc_call_t *call)
 {
-        size_t size = IPC_GET_ARG1(*call);
+        void *buf;
+        size_t size;
         int rc;
+        ipc_callid_t rcallid;
 
-        if (srv->srvs->ops->read == NULL) {
-                async_answer_0(callid, ENOTSUP);
+        if (!async_data_read_receive(&rcallid, &size)) {
+                async_answer_0(callid, EINVAL);
                 return;
         }
 
-        if (size <= 4 * sizeof(sysarg_t)) {
-                sysarg_t message[4] = {};
+        buf = malloc(size);
+        if (buf == NULL) {
+                async_answer_0(rcallid, ENOMEM);
+                async_answer_0(callid, ENOMEM);
+                return;
+        }
 
-                rc = srv->srvs->ops->read(srv, (char *)message, size);
-                async_answer_4(callid, rc, message[0], message[1],
-                    message[2], message[3]);
-        } else {
-                async_answer_0(callid, ELIMIT);
+        if (srv->srvs->ops->read == NULL) {
+                async_answer_0(rcallid, ENOTSUP);
+                async_answer_0(callid, ENOTSUP);
+                free(buf);
+                return;
         }
+
+        rc = srv->srvs->ops->read(srv, buf, size);
+        if (rc < 0) {
+                async_answer_0(rcallid, rc);
+                async_answer_0(callid, rc);
+                free(buf);
+                return;
+        }
+
+        async_data_read_finalize(rcallid, buf, size);
+
+        free(buf);
+        async_answer_2(callid, EOK, EOK, rc /* nread */);
 }
 
@@ -68 +87 @@
     ipc_call_t *call)
 {
-        size_t size = IPC_GET_ARG1(*call);
+        void *data;
+        size_t size;
         int rc;
+
+        rc = async_data_write_accept(&data, false, 0, 0, 0, &size);
+        if (rc != EOK) {
+                async_answer_0(callid, rc);
+                return;
+        }
 
         if (srv->srvs->ops->write == NULL) {
@@ -76 +102 @@
         }
 
-        if (size <= 3 * sizeof(sysarg_t)) {
-                const sysarg_t message[3] = {
-                        IPC_GET_ARG2(*call),
-                        IPC_GET_ARG3(*call),
-                        IPC_GET_ARG4(*call)
-                };
+        rc = srv->srvs->ops->write(srv, data, size);
+        free(data);
+        if (rc < 0)
+                async_answer_0(callid, rc);
 
-                rc = srv->srvs->ops->write(srv, (char *)message, size);
-                async_answer_0(callid, rc);
-        } else {
-                async_answer_0(callid, ELIMIT);
-        }
+        async_answer_2(callid, EOK, EOK, rc /* nwritten */);
 }