Changeset 195b7b3 in mainline for uspace/srv/hid/display/output.c

Timestamp:

2020-06-22T15:25:48Z (4 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

c8e1f93

Parents:

5271e4c

Message:

Clean up debug messages and logging

File:

• uspace/srv/hid/display/output.c (modified) (7 diffs)

uspace/srv/hid/display/output.c

@@ -38 +38 @@
 #include <fibril_synch.h>
 #include <io/kbd_event.h>
+#include <io/log.h>
 #include <io/pos_event.h>
 #include <loc.h>
-#include <stdio.h>
 #include <stdlib.h>
 #include "ddev.h"
@@ -63 +63 @@
             IPC_FLAG_BLOCKING);
         if (rc != EOK) {
-                printf("Error looking up category 'display-device'.\n");
+                log_msg(LOG_DEFAULT, LVL_ERROR,
+                    "Error looking up category 'display-device'.\n");
                 return EIO;
         }
@@ -72 +73 @@
         rc = loc_category_get_svcs(ddev_cid, &svcs, &count);
         if (rc != EOK) {
-                printf("Error getting list of display devices.\n");
+                log_msg(LOG_DEFAULT, LVL_ERROR,
+                    "Error getting list of display devices.\n");
                 return EIO;
         }
@@ -90 +92 @@
                         rc = ds_ddev_open(output->def_display, svcs[i], &nddev);
                         if (rc != EOK) {
-                                printf("Error adding display device.\n");
+                                log_msg(LOG_DEFAULT, LVL_ERROR,
+                                    "Error adding display device.\n");
                                 continue;
                         }
@@ -96 +99 @@
                         list_append(&nddev->loutdevs, &output->ddevs);
 
-                        printf("Added display device '%lu'\n",
+                        log_msg(LOG_DEFAULT, LVL_NOTE,
+                            "Added display device '%lu'\n",
                             (unsigned long) svcs[i]);
                 }
@@ -114 +118 @@
         ds_output_t *output = (ds_output_t *) arg;
 
-        printf("ds_ddev_change_cb\n");
         fibril_mutex_lock(&output->lock);
         (void) ds_output_check_new_devs(output);
@@ -151 +154 @@
         rc = loc_register_cat_change_cb(ds_ddev_change_cb, output);
         if (rc != EOK) {
-                printf("Failed registering callback for device discovery.\n");
+                log_msg(LOG_DEFAULT, LVL_ERROR,
+                    "Failed registering callback for device discovery.\n");
                 return rc;
         }