Changeset 174be87 in mainline for uspace/lib/ui/src/pbutton.c

Timestamp:

2022-05-24T14:48:00Z (2 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5877de74

Parents:

0415776

git-author:

Jiri Svoboda <jiri@…> (2022-05-23 17:47:45)

git-committer:

Jiri Svoboda <jiri@…> (2022-05-24 14:48:00)

Message:

Prevent using button after free

When a button is released (after being pressed), it generates two
callbacks, 'clicked' and 'up'. If the handler of the former
closes/destroys the dialog, the second event is delivered to an
already destroyed/freed dialog.

By delivering 'up' first and 'clicked' second, we can prevent this
particular problem. Is it the right solution? Not sure.

File:

• uspace/lib/ui/src/pbutton.c (modified) (2 diffs)

uspace/lib/ui/src/pbutton.c

@@ -480 +480 @@
 
         pbutton->held = false;
+        ui_pbutton_up(pbutton);
 
         if (pbutton->inside) {
@@ -485 +486 @@
                 ui_pbutton_clicked(pbutton);
         }
-
-        ui_pbutton_up(pbutton);
 }