Changeset 14f1db0 in mainline for uspace/lib/socket/generic/net_modules.c

Timestamp:

2010-04-09T12:54:57Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a1caa3c2

Parents:

24ab58b3

Message:

networking overhaul:

• separation of conserns
• removal of (almost all) overlaping symbols, libnetif is not needed anymore
• again, it is possible to build the networking in multiple architecture configurations (however, currently only the bundling netif and nil layers is supported, more to come)
• code style updates and fixes (still a huge amount of work to do)

File:

• uspace/lib/socket/generic/net_modules.c (modified) (2 diffs)

uspace/lib/socket/generic/net_modules.c

@@ -77 +77 @@
 }
 
-int bind_service(services_t need, ipcarg_t arg1, ipcarg_t arg2, ipcarg_t arg3, async_client_conn_t client_receiver){
+/** Create bidirectional connection with the needed module service and registers the message receiver.
+ *
+ * @param[in] need            The needed module service.
+ * @param[in] arg1            The first parameter.
+ * @param[in] arg2            The second parameter.
+ * @param[in] arg3            The third parameter.
+ * @param[in] client_receiver The message receiver.
+ *
+ * @return The phone of the needed service.
+ * @return Other error codes as defined for the ipc_connect_to_me() function.
+ *
+ */
+int bind_service(services_t need, ipcarg_t arg1, ipcarg_t arg2, ipcarg_t arg3,
+    async_client_conn_t client_receiver)
+{
         return bind_service_timeout(need, arg1, arg2, arg3, client_receiver, 0);
 }
 
-int bind_service_timeout(services_t need, ipcarg_t arg1, ipcarg_t arg2, ipcarg_t arg3, async_client_conn_t client_receiver, suseconds_t timeout){
+/** Create bidirectional connection with the needed module service and registers the message receiver.
+ *
+ * @param[in] need            The needed module service.
+ * @param[in] arg1            The first parameter.
+ * @param[in] arg2            The second parameter.
+ * @param[in] arg3            The third parameter.
+ * @param[in] client_receiver The message receiver.
+ * @param[in] timeout         The connection timeout in microseconds.
+ *                            No timeout if set to zero (0).
+ *
+ * @return The phone of the needed service.
+ * @return ETIMEOUT if the connection timeouted.
+ * @return Other error codes as defined for the ipc_connect_to_me() function.
+ *
+ */
+int bind_service_timeout(services_t need, ipcarg_t arg1, ipcarg_t arg2,
+    ipcarg_t arg3, async_client_conn_t client_receiver, suseconds_t timeout)
+{
         ERROR_DECLARE;
-
-        int phone;
-        ipcarg_t phonehash;
-
-        // connect to the needed service
-        phone = connect_to_service_timeout(need, timeout);
-        // if connected
-        if(phone >= 0){
-                // request the bidirectional connection
-                if(ERROR_OCCURRED(ipc_connect_to_me(phone, arg1, arg2, arg3, &phonehash))){
+        
+        /* Connect to the needed service */
+        int phone = connect_to_service_timeout(need, timeout);
+        if (phone >= 0) {
+                /* Request the bidirectional connection */
+                ipcarg_t phonehash;
+                if (ERROR_OCCURRED(ipc_connect_to_me(phone, arg1, arg2, arg3,
+                    &phonehash))) {
                         ipc_hangup(phone);
                         return ERROR_CODE;
@@ -98 +127 @@
                 async_new_connection(phonehash, 0, NULL, client_receiver);
         }
+        
         return phone;
 }