Changeset 10059a68 in mainline

Timestamp:

2011-10-31T10:54:31Z (13 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

90d7033

Parents:

ae754e5f

Message:

libusbdev: Warn if error handling fails.

File:

• uspace/lib/usbdev/src/hub.c (modified) (2 diffs)

uspace/lib/usbdev/src/hub.c

@@ -177 +177 @@
  * @param[in] arg Any data argument to @p enable_port.
  * @param[out] assigned_address USB address of the device.
- * @param[in] dev_ops Child device ops.
+ * @param[in] dev_ops Child device ops. Will use default if not provided.
  * @param[in] new_dev_data Arbitrary pointer to be stored in the child
  *      as @c driver_data.
@@ -357 +357 @@
          */
 leave_release_default_address:
-        usb_pipe_unregister(&ctrl_pipe, &hc_conn);
+        if (usb_pipe_unregister(&ctrl_pipe, &hc_conn) != EOK)
+                usb_log_warning("%s: Failed to unregister default pipe.\n",
+                    __FUNCTION__);
 
 leave_release_free_address:
-        usb_hc_unregister_device(&hc_conn, dev_addr);
+        if (usb_hc_unregister_device(&hc_conn, dev_addr) != EOK)
+                usb_log_warning("%s: Failed to unregister device.\n",
+                    __FUNCTION__);
 
 close_connection:
         if (usb_hc_connection_close(&hc_conn) != EOK)
-                usb_log_warning("usb_hc_new_device_wrapper(): Failed to close "
-                    "connection.\n");
+                usb_log_warning("%s: Failed to close connection.\n",
+                    __FUNCTION__);
 
         return rc;